From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>, linux-next@vger.kernel.org
Subject: Re: pci_ioremap_bar() breaks s390 build
Date: Mon, 20 Oct 2008 11:14:55 -0700 [thread overview]
Message-ID: <200810201114.55518.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <20081020181207.GA15328@osiris.boeblingen.de.ibm.com>
On Monday, October 20, 2008 11:12 am Heiko Carstens wrote:
> On Mon, Oct 20, 2008 at 10:47:41AM -0700, Arjan van de Ven wrote:
> > Heiko Carstens wrote:
> >> Hi Arjan,
> >>
> >> your patch "PCI: introduce an pci_ioremap(pdev, barnr) function" breaks
> >> s390:
> >>
> >> CC fs/compat_ioctl.o
> >> In file included from fs/compat_ioctl.c:52:
> >> include/linux/pci.h: In function 'pci_ioremap_bar':
> >> include/linux/pci.h:1136: error: implicit declaration of function
> >> 'ioremap_nocache' include/linux/pci.h:1137: warning: return makes
> >> pointer from integer without a cast make[1]: *** [fs/compat_ioctl.o]
> >> Error 1
> >> make: *** [fs] Error 2
> >
> > hmm does s390 have ioremap ?
> > since that'd be the most useful solution, to add an ioremap_nocache().
>
> s390 doesn't have ioremap.
>
> > if it doesn't have ioremap.. wtf is it doing using pci.h then ??
>
> Several common code parts pull pci.h, not s390.
> fs/compat_ioctl.c is one, drivers/scsi/scsi_lib.c is another one.
Hm, well it would probably be best to fix those (maybe add some #ifdef
CONFIG_PCI to them or somesuch), but that could get ugly. I'll go ahead and
apply your initial patch.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2008-10-20 18:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 17:45 pci_ioremap_bar() breaks s390 build Heiko Carstens
2008-10-20 17:47 ` Arjan van de Ven
2008-10-20 18:12 ` Jesse Barnes
2008-10-20 18:12 ` Heiko Carstens
2008-10-20 18:14 ` Jesse Barnes [this message]
2008-10-20 18:22 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810201114.55518.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=arjan@linux.intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).