From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J.R. Mauro" Subject: Re: linux-next: build failure Date: Mon, 20 Oct 2008 18:34:35 -0400 Message-ID: <20081020223435.GA11079@localhost> References: <20081020230420.aa85f83b.sfr@canb.auug.org.au> <20081020154857.GC24666@kroah.com> <3aaafc130810200933s7299378eg6924089a58b9778a@mail.gmail.com> <20081020165142.GA7166@kroah.com> <20081020204750.GA22377@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from wx-out-0506.google.com ([66.249.82.224]:40900 "EHLO wx-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751587AbYJTWea (ORCPT ); Mon, 20 Oct 2008 18:34:30 -0400 Received: by wx-out-0506.google.com with SMTP id h27so927317wxd.4 for ; Mon, 20 Oct 2008 15:34:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20081020204750.GA22377@kroah.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Greg KH Cc: Stephen Rothwell , linux-next@vger.kernel.org, Christopher Harrer , Michael Miles , LKML , Andrew Morton , linus@kroah.com On Mon, Oct 20, 2008 at 01:47:50PM -0700, Greg KH wrote: > On Mon, Oct 20, 2008 at 09:51:42AM -0700, Greg KH wrote: > > On Mon, Oct 20, 2008 at 12:33:29PM -0400, J.R. Mauro wrote: > > > On Mon, Oct 20, 2008 at 11:48 AM, Greg KH wrote: > > > > On Mon, Oct 20, 2008 at 11:04:20PM +1100, Stephen Rothwell wrote: > > > >> Hi Greg, > > > >> > > > >> Today's linux-next build (powerpc allyesconfig) failed like this: > > > >> > > > >> In file included from drivers/staging/sxg/sxg.c:77: > > > >> drivers/staging/sxg/sxghif.h:859: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Compilation' > > > >> drivers/staging/sxg/sxg.c: In function 'sxg_transmit_packet': > > > >> drivers/staging/sxg/sxg.c:1949: error: 'SXG_SGL_BUF_SIZE' undeclared (first use in this function) > > > >> drivers/staging/sxg/sxg.c:1958: error: implicit declaration of function 'SXG_SGL_BUFFER' > > > >> drivers/staging/sxg/sxg.c:1958: warning: assignment makes pointer from integer without a cast > > > >> drivers/staging/sxg/sxg.c: In function 'sxg_mcast_set_mask': > > > >> drivers/staging/sxg/sxg.c:2846: warning: format '%llx' expects type 'long long unsigned int', but argument 5 has type 'u64' > > > >> > > > >> I applied the following patch. > > > > > > > > Ah, doh, sorry, I should have caught that. I'll go apply this to the > > > > tree, thanks. > > > > > > Greg, > > > > > > The slicoss driver also from Alacritech looks like it needs a depends > > > on X86 as well. Should the sxg and slicoss drivers from Alacritech be > > > doing things like this (sxg/sxghif.h:851, slicoss/slicoss.c:960): > > > > Yes, it needs it too. > > Hm, it already has this dependancy. In drivers/staging/slicoss/Kconfig > we have: > config SLICOSS > tristate "Alacritech Gigabit IS-NIC support" > depends on PCI && X86 && NETDEV_1000 > > So we should be fine here. Sorry about that, had to pull from Linus's tree > > thanks, > > greg k-h