From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: BUG: sleeping function called from invalid context at kernel/rwsem.c:131 XFS? (was: Re: linux-next: Tree for October 17) Date: Wed, 22 Oct 2008 19:28:29 +1100 Message-ID: <20081022082828.GN18495@disturbed> References: <20081017203710.GA27187@infradead.org> <20081017135510.7127c4e7@infradead.org> <20081020163327.GA15651@infradead.org> <20081020223549.GA21152@disturbed> <20081022075838.GK18495@disturbed> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from ipmail01.adl6.internode.on.net ([203.16.214.146]:20989 "EHLO ipmail01.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013AbYJVI2h (ORCPT ); Wed, 22 Oct 2008 04:28:37 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: Alexander Beregalov Cc: lachlan@sgi.com, Christoph Hellwig , Arjan van de Ven , xfs@oss.sgi.com, linux-next@vger.kernel.org, LKML On Wed, Oct 22, 2008 at 12:21:23PM +0400, Alexander Beregalov wrote: > > Ah, OK, I see the problem, though I don't understand why I'm not > > seeing the might_sleep() triggering all the time given that I always > > build with: > > > > $ grep SLEEP .config > > CONFIG_DEBUG_SPINLOCK_SLEEP=y > > > > Basically the above commit moved xfs_ilock() inside > > radix_tree_preload()/radix_tree_preload_end(), which means we are > > taking a rwsem() while we have an elevated preempt count. I'll > > get a patch out to fix it. > Could it cause the I/O dead lock or should I continue trying to reproduce it? The deadlock wouldn't be produced by the same thing that produced the sleeping-in-atomic warning. The missed unlock that I also fixed in the patch I just sent could possibly have caused that, but I'm just speculating on that... Cheers, Dave. -- Dave Chinner david@fromorbit.com