From: Ingo Molnar <mingo@elte.hu>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-next@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: linux-next: stackprotector tree build failure
Date: Wed, 22 Oct 2008 10:31:39 +0200 [thread overview]
Message-ID: <20081022083139.GA4369@elte.hu> (raw)
In-Reply-To: <20081022192725.5f5de711.sfr@canb.auug.org.au>
* Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Wed, 22 Oct 2008 09:29:23 +0200 Ingo Molnar <mingo@elte.hu> wrote:
> >
> > I've Cc:-ed Junio and the Git list as a general FYI - but it must be
> > frustrating to get such a bugreport, because i have no reproducer.
> >
> > git-rerere sometimes seems to be picking up the wrong resolution. VERY
> > rarely.
> >
> > It seems random and content dependent. Once it happened to
> > arch/x86/kernel/traps_32.c and now to kernel/fork.c. Along the ~170
> > successful resolutions i have in my tree right now. And i do many
> > conflict resolutions every day - and it happened only once every 6
> > months or so.
> >
> > (the arch/x86/kernel/traps_32.c one happened regularly, that's why i
> > thought it's content sha1 dependent, and not some corruption.)
> >
> > Next time it happens i'll be on the watchout and will save the complete
> > tree.
>
> I think rerere matches preimages on the SHA1 of the conflict (or its
> reverse), so sufficiently similar pieces of code will match. I would
> expect things like ext2/3/4 to be candidates. Did the traps_32.c one
> match one for traps_64.c?
>
> I may be mistaken, but I once followed the code in rerere to try to
> figure out how to fix a resolution.
the traps_32.c one was that git-rerere put in a traps_64.c end result.
So i ended up with a 32-bit kernel that tried to build a 64-bit piece of
code - fireworks. That condition persisted - i had to fix it up manually
all the time i integrated that portion of the tree. That too was i think
centered around a header file chunk - perhaps the #include section of
traps_32.c and traps_64.c was similar enough in that section?
Ingo
next prev parent reply other threads:[~2008-10-22 8:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 2:11 linux-next: stackprotector tree build failure Stephen Rothwell
2008-10-22 4:32 ` Ingo Molnar
2008-10-22 7:21 ` Stephen Rothwell
2008-10-22 7:29 ` Ingo Molnar
2008-10-22 8:27 ` Stephen Rothwell
2008-10-22 8:31 ` Stephen Rothwell
2008-10-22 8:31 ` Ingo Molnar [this message]
2008-10-22 17:41 ` Johannes Schindelin
2008-10-22 23:54 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022083139.GA4369@elte.hu \
--to=mingo@elte.hu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hpa@zytor.com \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).