From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alexander Beregalov <a.beregalov@gmail.com>,
lachlan@sgi.com, Arjan van de Ven <arjan@infradead.org>,
xfs@oss.sgi.com, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: BUG: sleeping function called from invalid context at kernel/rwsem.c:131 XFS? (was: Re: linux-next: Tree for October 17)
Date: Thu, 23 Oct 2008 08:10:28 +1100 [thread overview]
Message-ID: <20081022211028.GO18495@disturbed> (raw)
In-Reply-To: <20081022101351.GB11313@infradead.org>
On Wed, Oct 22, 2008 at 06:13:51AM -0400, Christoph Hellwig wrote:
> On Wed, Oct 22, 2008 at 07:25:50PM +1100, Dave Chinner wrote:
> > > Basically the above commit moved xfs_ilock() inside
> > > radix_tree_preload()/radix_tree_preload_end(), which means we are
> > > taking a rwsem() while we have an elevated preempt count. I'll
> > > get a patch out to fix it.
>
> This really needs a warning. Then again I don't really understand this
> as the point of radix_tree_preload was that we can do the actual
> radix-tree under a lock, or not?
Right - the preload allows us to do GFP_KERNEL allocations for radix
tree nodes and use a spinlock for inserts into the tree. We could
drop the preload stuff if we initialised the radix tree to use
GFP_ATOMIC allocations for radix tree nodes, but that is more likely
to lead to insert failures under low memory conditions compared to
the preload method.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-10-22 21:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 12:43 BUG: sleeping function called from invalid context at kernel/rwsem.c:131 XFS? (was: Re: linux-next: Tree for October 17) Alexander Beregalov
2008-10-17 16:41 ` Christoph Hellwig
2008-10-17 16:54 ` Alexander Beregalov
2008-10-17 16:57 ` Christoph Hellwig
2008-10-17 17:13 ` Alexander Beregalov
2008-10-17 20:37 ` Christoph Hellwig
2008-10-17 20:55 ` Arjan van de Ven
2008-10-20 14:58 ` Alexander Beregalov
2008-10-20 16:33 ` Christoph Hellwig
2008-10-20 17:13 ` Alexander Beregalov
2008-10-20 22:35 ` Dave Chinner
2008-10-21 11:42 ` Alexander Beregalov
2008-10-22 7:58 ` Dave Chinner
2008-10-22 8:21 ` Alexander Beregalov
2008-10-22 8:28 ` Dave Chinner
2008-10-22 8:25 ` Dave Chinner
2008-10-22 9:12 ` Alexander Beregalov
2008-10-22 10:13 ` Christoph Hellwig
2008-10-22 21:10 ` Dave Chinner [this message]
2008-10-22 15:06 ` BUG: sleeping function called from invalid context at kernel/rwsem.c:131 XFS? Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022211028.GO18495@disturbed \
--to=david@fromorbit.com \
--cc=a.beregalov@gmail.com \
--cc=arjan@infradead.org \
--cc=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).