From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, Ingo Molnar <mingo@elte.hu>, travis@sgi.com
Subject: Re: linux-next: rr tree build warning
Date: Fri, 24 Oct 2008 14:44:09 +1100 [thread overview]
Message-ID: <200810241444.09760.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20081024133407.8c4df5f6.sfr@canb.auug.org.au>
On Friday 24 October 2008 13:34:07 Stephen Rothwell wrote:
> Hi Rusty,
>
> Today's linux-next build (powerpc ppc64_defconfig) got this warning:
>
> kernel/workqueue.c: In function 'work_on_cpu':
> kernel/workqueue.c:1009: warning: passing argument 1 of 'flush_workqueue'
> from incompatible pointer type
>
> You are passing a "struct work_struct *" to fluxh_workqueue which wants a
> "struct workqueue_struct *".
Please s/flush_workqueue/flush_work/. Somehow I missed that warning (and
didn't re-test after that trivial change).
Tested, even.
diff -r 4d829bda1768 kernel/workqueue.c
--- a/kernel/workqueue.c Fri Oct 24 14:10:09 2008 +1100
+++ b/kernel/workqueue.c Fri Oct 24 14:10:58 2008 +1100
@@ -1006,7 +1006,7 @@ long work_on_cpu(unsigned int cpu, long
wfc.ret = -EINVAL;
else {
schedule_work_on(cpu, &wfc.work);
- flush_workqueue(&wfc.work);
+ flush_work(&wfc.work);
}
put_online_cpus();
Sorry,
Rusty.
next prev parent reply other threads:[~2008-10-24 3:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 2:34 linux-next: rr tree build warning Stephen Rothwell
2008-10-24 3:44 ` Rusty Russell [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-12-04 23:42 Stephen Rothwell
2009-01-08 4:54 Stephen Rothwell
2009-06-09 6:26 Stephen Rothwell
2009-06-10 6:40 ` Rusty Russell
2009-06-10 6:46 ` Stephen Rothwell
2009-11-12 8:21 Stephen Rothwell
2009-11-12 13:15 ` Rusty Russell
2009-12-16 3:58 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810241444.09760.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sfr@canb.auug.org.au \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).