From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH] tracing: fix a build error on alpha and m68k Date: Fri, 31 Oct 2008 10:55:44 +0100 Message-ID: <20081031095544.GI30317@elte.hu> References: <49008D12.5090204@gmail.com> <4900B414.7090002@gmail.com> <20081023163433.GA3160@x200.localdomain> <20081030214910.GA14679@x200.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-m68k-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Alexey Dobriyan , Frederic Weisbecker , Stephen Rothwell , linux-next@vger.kernel.org, Linux Kernel Development , Steven Rostedt , Linux/m68k List-Id: linux-next.vger.kernel.org * Geert Uytterhoeven wrote: > On Fri, 31 Oct 2008, Alexey Dobriyan wrote: > > On Thu, Oct 23, 2008 at 08:34:33PM +0400, Alexey Dobriyan wrote: > > > On Thu, Oct 23, 2008 at 07:27:48PM +0200, Frederic Weisbecker wrote: > > > > When tracing is enabled, some arch have included > > > > on their but others like alpha or m68k don't. > > > > > > > > Build error on alpha: > > > > > > > > kernel/trace/trace.c: In function 'tracing_generic_entry_update': > > > > kernel/trace/trace.c:658: error: implicit declaration of function 'irqs_disabled_flags' > > > > FYI, this error still exists in mainline (7f82f000ed030d1108b4de47d9e2d556092980c6). > > Now it hit mainline (I can't be bothered to develop _new_ code to > fix things in -next ;-), I'm implementing irqs_disabled_flags() for > m68k. Stay tuned... this (now mainline) commit should have fixed it: 9244489: ftrace: handle archs that do not support irqs_disabled_flags can you still see problems? Ingo