From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>, Andy Whitcroft <apw@shadowen.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
torvalds@linux-foundation.org, sfr@canb.auug.org.au,
linux-next@vger.kernel.org, srostedt@redhat.com
Subject: Re: [PATCH 1/1] ring-buffer: buffer record on/off switch
Date: Tue, 11 Nov 2008 22:08:31 +0100 [thread overview]
Message-ID: <20081111210831.GA16179@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0811111603590.3275@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Tue, 11 Nov 2008, Andrew Morton wrote:
>
> > On Tue, 11 Nov 2008 15:06:02 -0500
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > +static struct file_operations rb_simple_fops = {
> >
> > should be const...
> >
> > Probably it isn't worth fixing. Someone(tm) should do period sweeps -
> > 10% of our file_operationses aren't const.
>
> Thanks, I never really thought about it.
>
> I'll add to my todo list to send out a patch that cleans all of this
> up. I think I'm guilty at doing this in more than one place.
Perhaps checkpatch.pl could remind us about it? a new file_operations
struct definition should be const in 99.9% of the cases.
Ingo
next prev parent reply other threads:[~2008-11-11 21:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 20:06 [PATCH 0/1] ring-buffer: disable tracing switch Steven Rostedt
2008-11-11 20:06 ` [PATCH 1/1] ring-buffer: buffer record on/off switch Steven Rostedt
2008-11-11 20:56 ` Andrew Morton
2008-11-11 21:04 ` Steven Rostedt
2008-11-11 21:08 ` Ingo Molnar [this message]
2008-11-12 14:11 ` Andy Whitcroft
2008-11-11 21:06 ` Steven Rostedt
2008-11-12 12:51 ` Pavel Machek
2008-11-11 20:36 ` [PATCH 0/1] ring-buffer: disable tracing switch Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081111210831.GA16179@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).