From: Pavel Machek <pavel@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@linutronix.de,
torvalds@linux-foundation.org, sfr@canb.auug.org.au,
linux-next@vger.kernel.org, srostedt@redhat.com
Subject: Re: [PATCH 1/1] ring-buffer: buffer record on/off switch
Date: Wed, 12 Nov 2008 13:51:50 +0100 [thread overview]
Message-ID: <20081112125149.GA13192@ucw.cz> (raw)
In-Reply-To: <20081111125645.4f7a5827.akpm@linux-foundation.org>
On Tue 2008-11-11 12:56:45, Andrew Morton wrote:
> On Tue, 11 Nov 2008 15:06:02 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > +static struct file_operations rb_simple_fops = {
>
> should be const...
>
> Probably it isn't worth fixing. Someone(tm) should do period sweeps -
> 10% of our file_operationses aren't const.
checkptch rule? struct file_operations .* = { -> needs const?
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-11-12 12:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 20:06 [PATCH 0/1] ring-buffer: disable tracing switch Steven Rostedt
2008-11-11 20:06 ` [PATCH 1/1] ring-buffer: buffer record on/off switch Steven Rostedt
2008-11-11 20:56 ` Andrew Morton
2008-11-11 21:04 ` Steven Rostedt
2008-11-11 21:08 ` Ingo Molnar
2008-11-12 14:11 ` Andy Whitcroft
2008-11-11 21:06 ` Steven Rostedt
2008-11-12 12:51 ` Pavel Machek [this message]
2008-11-11 20:36 ` [PATCH 0/1] ring-buffer: disable tracing switch Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081112125149.GA13192@ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).