Re: linux-next: rr tree build failure

[Greg KH <gregkh@suse.de>]

On Fri, Nov 21, 2008 at 09:28:51PM +1030, Rusty Russell wrote:
> On Friday 21 November 2008 13:49:13 Stephen Rothwell wrote:
> > Hi Rusty,
> >
> > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> >
> > drivers/usb/core/usb.c:958:76: error: macro "__module_param_call" requires
> > 7 arguments, but only 6 given
> >
> > Caused by commit 636c06e04b23e9dabf709c496cb9a28459f63eaa
> > ("param:core_param-really-really-early").
> >
> > I have dropped the rr tree again.
> 
> Yes, I didn't get a reply from Greg about whether he really needs "nousb" to
> be a module param, so I dropped my proposed USB fix.  I've restored it now.
> 
> Greg, here's the complete patch I have now:
> 
> Subject: USB: Use core_param.
> 
> Found this when I changed args to __module_param_call.  We now have
> core_param for exactly this.
> 
> This reverts to the 2005 (pre- aafbf24a) behaviour where "nousb" was
> not a module parameter, just a kernel command line parameter.  That's
> more sensible anyway.

No, please stick with the post 2005 behavior :)

thanks,

greg k-h