From mboxrd@z Thu Jan 1 00:00:00 1970 From: "John W. Linville" Subject: Re: linux-next: ftrace tree build failure Date: Tue, 25 Nov 2008 09:57:01 -0500 Message-ID: <20081125145701.GA25962@tuxdriver.com> References: <20081125140719.03a8cdfb.sfr@canb.auug.org.au> <20081125072801.GA15592@elte.hu> <20081125184335.330cf28e.sfr@canb.auug.org.au> <20081125080410.GA28912@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:42322 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751379AbYKYPBS (ORCPT ); Tue, 25 Nov 2008 10:01:18 -0500 Content-Disposition: inline In-Reply-To: <20081125080410.GA28912@elte.hu> Sender: linux-next-owner@vger.kernel.org List-ID: To: Ingo Molnar Cc: Stephen Rothwell , Thomas Gleixner , "H. Peter Anvin" , linux-next@vger.kernel.org, Steven Rostedt , "Luis R. Rodriguez" , "David S. Miller" On Tue, Nov 25, 2008 at 09:04:10AM +0100, Ingo Molnar wrote: > > * Stephen Rothwell wrote: > > > Hi Ingo, > > > > On Tue, 25 Nov 2008 08:28:01 +0100 Ingo Molnar wrote: > > > > > > this fix is wrong - the intention of that line was to add a proper > > > WARN(), not a WARN_ON(). Your change loses the message that WARN() > > > prints. > > > > > > i posted a tested fix for this two days ago: > > > > > > http://marc.info/?l=linux-kernel&m=122745649425646&w=2 > > > > > > see it also below. > > > > Yeah, Steve told me. However, it might have been useful to tell the > > wireless maintainer, the network maintainer and the original author > > (and probably netdev - which I also left off). > > yep, i too forgot to add full Cc:s (it was in the context of a tracing > discussion) - but lkml was Cc:-ed so it wasnt actually lost. I have the patch now...thanks! Now, if I only knew why my build didn't fail with the original code... John -- John W. Linville Linux should be at the core linville@tuxdriver.com of your literate lifestyle.