From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Subject: Re: linux-next: ftrace tree build failure
Date: Tue, 25 Nov 2008 10:46:30 -0800
Message-ID: <20081125184630.GA5950@tesla>
References: <20081125140719.03a8cdfb.sfr@canb.auug.org.au> <20081125072801.GA15592@elte.hu> <20081125184335.330cf28e.sfr@canb.auug.org.au> <20081125080410.GA28912@elte.hu> <20081125145701.GA25962@tuxdriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Return-path: <linux-next-owner@vger.kernel.org>
Received: from mail.atheros.com ([12.36.123.2]:44144 "EHLO mail.atheros.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751976AbYKYSqb (ORCPT <rfc822;linux-next@vger.kernel.org>);
	Tue, 25 Nov 2008 13:46:31 -0500
Received: from mail.atheros.com ([10.10.20.108])
	by sidewinder.atheros.com
	for <linux-next@vger.kernel.org>; Tue, 25 Nov 2008 10:46:31 -0800
Content-Disposition: inline
In-Reply-To: <20081125145701.GA25962@tuxdriver.com>
Sender: linux-next-owner@vger.kernel.org
List-ID: <linux-next.vger.kernel.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Ingo Molnar <mingo@elte.hu>, Stephen Rothwell <sfr@canb.auug.org.au>, Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>, "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>, Steven Rostedt <srostedt@redhat.com>, Luis Rodriguez <Luis.Rodriguez@Atheros.com>, "David S. Miller" <davem@davemloft.net>

On Tue, Nov 25, 2008 at 06:57:01AM -0800, John W. Linville wrote:
> On Tue, Nov 25, 2008 at 09:04:10AM +0100, Ingo Molnar wrote:
> >
> > * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > > Hi Ingo,
> > >
> > > On Tue, 25 Nov 2008 08:28:01 +0100 Ingo Molnar <mingo@elte.hu> wrote:
> > > >
> > > > this fix is wrong - the intention of that line was to add a proper
> > > > WARN(), not a WARN_ON(). Your change loses the message that WARN()
> > > > prints.
> > > >
> > > > i posted a tested fix for this two days ago:
> > > >
> > > >   http://marc.info/?l=linux-kernel&m=122745649425646&w=2
> > > >
> > > > see it also below.
> > >
> > > Yeah, Steve told me.  However, it might have been useful to tell the
> > > wireless maintainer, the network maintainer and the original author
> > > (and probably netdev - which I also left off).
> >
> > yep, i too forgot to add full Cc:s (it was in the context of a tracing
> > discussion) - but lkml was Cc:-ed so it wasnt actually lost.
> 
> I have the patch now...thanks!
> 
> Now, if I only knew why my build didn't fail with the original code...

Same here I run tests with sparse too prior to sending patches.

  Luis