From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "David S. Miller" <davem@davemloft.net>, linux-next@vger.kernel.org
Subject: Re: linux-next: sparc tree build failure
Date: Tue, 2 Dec 2008 21:52:25 +1030 [thread overview]
Message-ID: <200812022152.25989.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20081202172413.f14fe387.sfr@canb.auug.org.au>
On Tuesday 02 December 2008 16:54:13 Stephen Rothwell wrote:
> Hi Dave,
>
> Today's linux-next build (sparc defconfig) failed like this:
>
> lib/find_next_bit.c: In function 'find_last_bit':
> lib/find_next_bit.c:183: error: implicit declaration of function '__fls'
Thanks Stephen... that's a surprise.
Dave, I think this is a sparc issue.
sparc: asm/bitops.h should define __fls
bitops_64.h includes the generic one; pretty sure 32 should too.
(Found by using __fls in generic code and breaking sparc defconfig build:
thanks Stephen and linux-next!)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff --git a/arch/sparc/include/asm/bitops_32.h b/arch/sparc/include/asm/bitops_32.h
--- a/arch/sparc/include/asm/bitops_32.h
+++ b/arch/sparc/include/asm/bitops_32.h
@@ -98,6 +98,7 @@ static inline void change_bit(unsigned l
#include <asm-generic/bitops/sched.h>
#include <asm-generic/bitops/ffs.h>
#include <asm-generic/bitops/fls.h>
+#include <asm-generic/bitops/__fls.h>
#include <asm-generic/bitops/fls64.h>
#include <asm-generic/bitops/hweight.h>
#include <asm-generic/bitops/lock.h>
next prev parent reply other threads:[~2008-12-02 11:22 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 6:24 linux-next: sparc tree build failure Stephen Rothwell
2008-12-02 11:22 ` Rusty Russell [this message]
2008-12-04 0:04 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-11-26 9:16 Stephen Rothwell
2009-11-26 23:28 ` David Miller
2009-11-27 9:00 ` Thomas Gleixner
2009-11-06 7:02 Stephen Rothwell
2009-11-06 8:19 ` David Miller
2009-11-06 8:26 ` David Miller
2009-11-06 8:27 ` David Miller
2009-11-07 2:35 ` Stephen Rothwell
2009-11-05 7:50 Stephen Rothwell
2009-11-05 7:53 ` David Miller
2009-11-05 8:00 ` David Miller
2009-11-05 14:44 ` Kristoffer Glembo
2009-11-13 10:34 ` Kristoffer Glembo
2009-11-13 14:57 ` David Miller
2009-10-05 7:43 Stephen Rothwell
2009-10-05 7:45 ` David Miller
2009-04-09 5:17 Stephen Rothwell
2009-04-09 5:27 ` Ingo Molnar
2009-04-09 5:28 ` David Miller
2009-04-09 5:36 ` Ingo Molnar
2009-04-09 5:40 ` David Miller
2009-04-09 5:53 ` Ingo Molnar
2009-04-09 5:59 ` David Miller
2009-04-09 5:28 ` David Miller
2009-04-14 3:45 ` Stephen Rothwell
2008-12-04 8:54 Stephen Rothwell
2008-12-04 11:47 ` Sam Ravnborg
2008-11-30 23:46 Stephen Rothwell
2008-12-01 5:41 ` Sam Ravnborg
2008-12-01 7:23 ` David Miller
2008-07-28 6:38 Stephen Rothwell
2008-07-28 8:21 ` Sam Ravnborg
2008-07-28 9:31 ` Adrian Bunk
2008-07-28 15:12 ` Stephen Rothwell
2008-07-28 10:12 ` Stephen Rothwell
2008-07-28 11:16 ` Sam Ravnborg
2008-07-25 7:05 Stephen Rothwell
2008-07-25 7:09 ` Stephen Rothwell
2008-07-26 9:25 ` David Miller
2008-08-04 4:26 ` David Miller
2008-08-04 5:35 ` Stephen Rothwell
2008-07-22 7:41 Stephen Rothwell
2008-07-22 22:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812022152.25989.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=davem@davemloft.net \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).