From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: m68k 8390 breakage Date: Wed, 03 Dec 2008 22:18:15 -0800 (PST) Message-ID: <20081203.221815.80265808.davem@davemloft.net> References: <20081203115622.50256091@extreme> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: netdev-owner@vger.kernel.org To: geert@linux-m68k.org Cc: shemminger@vyatta.com, sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-next.vger.kernel.org From: Geert Uytterhoeven Date: Wed, 3 Dec 2008 21:38:41 +0100 (CET) > Oops, the log above is from allmodconfig and indeed doesn't show it. > > mac_defconfig (which has CONFIG_MAC8390=y) shows more info: > > | drivers/net/lib8390.c:303: warning: '__ei_start_xmit' defined but not used > | drivers/net/lib8390.c:881: warning: '__ei_get_stats' defined but not used > | drivers/net/lib8390.c:990: warning: '__ei_set_multicast_list' defined but not > | ... > | drivers/built-in.o: In function `ethdev_setup': > | mac8390.c:(.text+0x29684): undefined reference to `ei_start_xmit' > | mac8390.c:(.text+0x2968c): undefined reference to `ei_get_stats' > | mac8390.c:(.text+0x29694): undefined reference to `ei_set_multicast_list' > > defconfig log at http://kisskb.ellerman.id.au/kisskb/buildresult/58646/ This mac8390 driver uses the lib8390.c/8390.[ch] mechanism a little bit oddly, but of course we should not have broken it :-) Stephen please take a look, thanks!