linux-next: staging tree build failure

linux-next: staging tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 3766 bytes --]

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/staging/agnx/xmit.c: In function 'fill_agnx_hdr':
drivers/staging/agnx/xmit.c:629: error: 'struct <anonymous>' has no member named 'retry_limit'
drivers/staging/agnx/xmit.c:630: error: 'struct <anonymous>' has no member named 'retry_limit'
drivers/staging/agnx/xmit.c: In function 'txm_power_set':
drivers/staging/agnx/xmit.c:652: error: 'struct ieee80211_tx_info' has no member named 'tx_rate_idx'
drivers/staging/agnx/xmit.c:652: error: 'struct ieee80211_tx_info' has no member named 'tx_rate_idx'
drivers/staging/agnx/xmit.c:652: error: 'struct ieee80211_tx_info' has no member named 'tx_rate_idx'
drivers/staging/agnx/pci.c: In function 'agnx_config_interface':
drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid'
drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid'
drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid'
drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
drivers/staging/agnx/pci.c:329: error: 'struct ieee80211_if_conf' has no member named 'ssid'
drivers/staging/agnx/pci.c:329: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
drivers/staging/agnx/pci.c:330: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
drivers/staging/agnx/pci.c:331: error: 'struct ieee80211_if_conf' has no member named 'ssid'
drivers/staging/agnx/pci.c:331: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
drivers/staging/agnx/pci.c: At top level:
drivers/staging/agnx/pci.c:432: warning: initialization from incompatible pointer type
drivers/staging/altpciechdma/altpciechdma.c: In function 'ape_sg_to_chdma_table':
drivers/staging/altpciechdma/altpciechdma.c:430: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
drivers/staging/altpciechdma/altpciechdma.c:434: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
drivers/staging/altpciechdma/altpciechdma.c:450: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
drivers/staging/altpciechdma/altpciechdma.c:451: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
drivers/staging/altpciechdma/altpciechdma.c: In function 'dma_test':
drivers/staging/altpciechdma/altpciechdma.c:548: warning: assignment makes integer from pointer without a cast
drivers/staging/altpciechdma/altpciechdma.c: In function 'probe':
drivers/staging/altpciechdma/altpciechdma.c:931: warning: label 'err_rev' defined but not used
drivers/staging/altpciechdma/altpciechdma.c:914: warning: label 'err_cdev' defined but not used
drivers/staging/altpciechdma/altpciechdma.c: At top level:
drivers/staging/altpciechdma/altpciechdma.c:416: warning: 'ape_sg_to_chdma_table' defined but not used

Commit "STAGING: Move staging drivers back to staging-specific menu"
allowed them to build in the allmodconfig again.  I have dropped the
staging tree for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: staging tree build failure

[Dmitry Baryshkov]

Stephen Rothwell пишет:
> Hi Greg,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> drivers/staging/agnx/xmit.c: In function 'fill_agnx_hdr':
> drivers/staging/agnx/xmit.c:629: error: 'struct <anonymous>' has no member named 'retry_limit'
> drivers/staging/agnx/xmit.c:630: error: 'struct <anonymous>' has no member named 'retry_limit'
> drivers/staging/agnx/xmit.c: In function 'txm_power_set':
> drivers/staging/agnx/xmit.c:652: error: 'struct ieee80211_tx_info' has no member named 'tx_rate_idx'
> drivers/staging/agnx/xmit.c:652: error: 'struct ieee80211_tx_info' has no member named 'tx_rate_idx'
> drivers/staging/agnx/xmit.c:652: error: 'struct ieee80211_tx_info' has no member named 'tx_rate_idx'
> drivers/staging/agnx/pci.c: In function 'agnx_config_interface':
> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid'
> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid'
> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid'
> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
> drivers/staging/agnx/pci.c:329: error: 'struct ieee80211_if_conf' has no member named 'ssid'
> drivers/staging/agnx/pci.c:329: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
> drivers/staging/agnx/pci.c:330: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
> drivers/staging/agnx/pci.c:331: error: 'struct ieee80211_if_conf' has no member named 'ssid'
> drivers/staging/agnx/pci.c:331: error: 'struct ieee80211_if_conf' has no member named 'ssid_len'
> drivers/staging/agnx/pci.c: At top level:
> drivers/staging/agnx/pci.c:432: warning: initialization from incompatible pointer type
> drivers/staging/altpciechdma/altpciechdma.c: In function 'ape_sg_to_chdma_table':
> drivers/staging/altpciechdma/altpciechdma.c:430: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
> drivers/staging/altpciechdma/altpciechdma.c:434: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
> drivers/staging/altpciechdma/altpciechdma.c:450: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
> drivers/staging/altpciechdma/altpciechdma.c:451: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
> drivers/staging/altpciechdma/altpciechdma.c: In function 'dma_test':
> drivers/staging/altpciechdma/altpciechdma.c:548: warning: assignment makes integer from pointer without a cast
> drivers/staging/altpciechdma/altpciechdma.c: In function 'probe':
> drivers/staging/altpciechdma/altpciechdma.c:931: warning: label 'err_rev' defined but not used
> drivers/staging/altpciechdma/altpciechdma.c:914: warning: label 'err_cdev' defined but not used
> drivers/staging/altpciechdma/altpciechdma.c: At top level:
> drivers/staging/altpciechdma/altpciechdma.c:416: warning: 'ape_sg_to_chdma_table' defined but not used
> 
> Commit "STAGING: Move staging drivers back to staging-specific menu"
> allowed them to build in the allmodconfig again.  I have dropped the
> staging tree for today.
> 

Damn. And w/o that commit staging drivers pollute the main drivers menu.

-- 
With best wishes
Dmitry

Re: linux-next: staging tree build failure

[Greg KH]

On Mon, Dec 08, 2008 at 01:34:34PM +0300, Dmitry Baryshkov wrote:
> Stephen Rothwell пишет:
>> Hi Greg,
>> Today's linux-next build (x86_64 allmodconfig) failed like this:
>> drivers/staging/agnx/xmit.c: In function 'fill_agnx_hdr':
>> drivers/staging/agnx/xmit.c:629: error: 'struct <anonymous>' has no member 
>> named 'retry_limit'
>> drivers/staging/agnx/xmit.c:630: error: 'struct <anonymous>' has no member 
>> named 'retry_limit'
>> drivers/staging/agnx/xmit.c: In function 'txm_power_set':
>> drivers/staging/agnx/xmit.c:652: error: 'struct ieee80211_tx_info' has no 
>> member named 'tx_rate_idx'
>> drivers/staging/agnx/xmit.c:652: error: 'struct ieee80211_tx_info' has no 
>> member named 'tx_rate_idx'
>> drivers/staging/agnx/xmit.c:652: error: 'struct ieee80211_tx_info' has no 
>> member named 'tx_rate_idx'
>> drivers/staging/agnx/pci.c: In function 'agnx_config_interface':
>> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no 
>> member named 'ssid_len'
>> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no 
>> member named 'ssid'
>> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no 
>> member named 'ssid_len'
>> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no 
>> member named 'ssid_len'
>> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no 
>> member named 'ssid'
>> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no 
>> member named 'ssid_len'
>> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no 
>> member named 'ssid_len'
>> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no 
>> member named 'ssid'
>> drivers/staging/agnx/pci.c:327: error: 'struct ieee80211_if_conf' has no 
>> member named 'ssid_len'
>> drivers/staging/agnx/pci.c:329: error: 'struct ieee80211_if_conf' has no 
>> member named 'ssid'
>> drivers/staging/agnx/pci.c:329: error: 'struct ieee80211_if_conf' has no 
>> member named 'ssid_len'
>> drivers/staging/agnx/pci.c:330: error: 'struct ieee80211_if_conf' has no 
>> member named 'ssid_len'
>> drivers/staging/agnx/pci.c:331: error: 'struct ieee80211_if_conf' has no 
>> member named 'ssid'
>> drivers/staging/agnx/pci.c:331: error: 'struct ieee80211_if_conf' has no 
>> member named 'ssid_len'
>> drivers/staging/agnx/pci.c: At top level:
>> drivers/staging/agnx/pci.c:432: warning: initialization from incompatible 
>> pointer type
>> drivers/staging/altpciechdma/altpciechdma.c: In function 
>> 'ape_sg_to_chdma_table':
>> drivers/staging/altpciechdma/altpciechdma.c:430: warning: format '%08x' 
>> expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
>> drivers/staging/altpciechdma/altpciechdma.c:434: warning: format '%08x' 
>> expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
>> drivers/staging/altpciechdma/altpciechdma.c:450: warning: format '%08x' 
>> expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
>> drivers/staging/altpciechdma/altpciechdma.c:451: warning: format '%08x' 
>> expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
>> drivers/staging/altpciechdma/altpciechdma.c: In function 'dma_test':
>> drivers/staging/altpciechdma/altpciechdma.c:548: warning: assignment makes 
>> integer from pointer without a cast
>> drivers/staging/altpciechdma/altpciechdma.c: In function 'probe':
>> drivers/staging/altpciechdma/altpciechdma.c:931: warning: label 'err_rev' 
>> defined but not used
>> drivers/staging/altpciechdma/altpciechdma.c:914: warning: label 'err_cdev' 
>> defined but not used
>> drivers/staging/altpciechdma/altpciechdma.c: At top level:
>> drivers/staging/altpciechdma/altpciechdma.c:416: warning: 
>> 'ape_sg_to_chdma_table' defined but not used
>> Commit "STAGING: Move staging drivers back to staging-specific menu"
>> allowed them to build in the allmodconfig again.  I have dropped the
>> staging tree for today.
>
> Damn. And w/o that commit staging drivers pollute the main drivers menu.

Very wierd.  Dmitry, care to look into this today?

thanks,

greg k-h

[PATCH] staging: really fix up Kconfig automatic deselction

[Dmitry Eremin-Solenikov]

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 drivers/staging/Kconfig |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index 4089f14..1905919 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -39,6 +39,8 @@ config STAGING_EXCLUDE_BUILD
 	  when selecting 'make allyesconfg' and 'make allmodconfig' so
 	  don't be all that put off, your dog will be just fine.
 
+if !STAGING_EXCLUDE_BUILD
+
 source "drivers/staging/et131x/Kconfig"
 
 source "drivers/staging/slicoss/Kconfig"
@@ -62,3 +64,5 @@ source "drivers/staging/at76_usb/Kconfig"
 source "drivers/staging/poch/Kconfig"
 
 endif # !STAGING_EXCLUDE_BUILD
+
+endif # STAGING
-- 
1.5.6.5

Re: [PATCH] staging: really fix up Kconfig automatic deselction

[Greg KH]

On Tue, Dec 09, 2008 at 04:10:51AM +0300, Dmitry Eremin-Solenikov wrote:
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>

This patch should be used instead of your current one in my tree, right?
Or apply it on top of your current one?

thanks,

greg k-h

Re: [PATCH] staging: really fix up Kconfig automatic deselction

[Dmitry Eremin-Solenikov]

Greg KH wrote:
> On Tue, Dec 09, 2008 at 04:10:51AM +0300, Dmitry Eremin-Solenikov wrote:
>> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> 
> This patch should be used instead of your current one in my tree, right?
> Or apply it on top of your current one?

On top of the previous one. If you want, you can squash them into one 
commit, of course.

-- 
With best wishes
Dmitry

Re: [PATCH] staging: really fix up Kconfig automatic deselction

[Greg KH]

On Tue, Dec 09, 2008 at 07:32:44AM +0300, Dmitry Eremin-Solenikov wrote:
> Greg KH wrote:
>> On Tue, Dec 09, 2008 at 04:10:51AM +0300, Dmitry Eremin-Solenikov wrote:
>>> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
>> This patch should be used instead of your current one in my tree, right?
>> Or apply it on top of your current one?
>
> On top of the previous one. If you want, you can squash them into one 
> commit, of course.

I've merged them together now, thanks for the fix.

greg k-h

Re: linux-next: staging tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

Hi Greg,

On Mon, 8 Dec 2008 20:43:03 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> drivers/staging/agnx/xmit.c: In function 'fill_agnx_hdr':
> drivers/staging/agnx/xmit.c:629: error: 'struct <anonymous>' has no member named 'retry_limit'
> drivers/staging/agnx/xmit.c:630: error: 'struct <anonymous>' has no member named 'retry_limit'
	.
	.
	.
> 
> Commit "STAGING: Move staging drivers back to staging-specific menu"
> allowed them to build in the allmodconfig again.  I have dropped the
> staging tree for today.

This failure is still happening.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: staging tree build failure

[Greg KH]

On Thu, Dec 11, 2008 at 07:37:39PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Mon, 8 Dec 2008 20:43:03 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Today's linux-next build (x86_64 allmodconfig) failed like this:
> > 
> > drivers/staging/agnx/xmit.c: In function 'fill_agnx_hdr':
> > drivers/staging/agnx/xmit.c:629: error: 'struct <anonymous>' has no member named 'retry_limit'
> > drivers/staging/agnx/xmit.c:630: error: 'struct <anonymous>' has no member named 'retry_limit'
> 	.
> 	.
> 	.
> > 
> > Commit "STAGING: Move staging drivers back to staging-specific menu"
> > allowed them to build in the allmodconfig again.  I have dropped the
> > staging tree for today.
> 
> This failure is still happening.

Ick, sorry about that, this should now be fixed.

thanks,

greg k-h