From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Subject: Re: [BUILD-FAILURE] next-20081217-s390x-'struct device' has no
	member named 'knode_parent'
Date: Thu, 18 Dec 2008 22:47:08 +0530
Message-ID: <20081218171708.GA28135@linux.vnet.ibm.com>
References: <20081217232536.0b18f4a7.sfr@canb.auug.org.au> <20081217181745.GA18420@linux.vnet.ibm.com> <1229593665.7086.1.camel@localhost>
Reply-To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Return-path: <linux-next-owner@vger.kernel.org>
Received: from E23SMTP06.au.ibm.com ([202.81.18.175]:54154 "EHLO
	e23smtp06.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750915AbYLRRR5 (ORCPT
	<rfc822;linux-next@vger.kernel.org>); Thu, 18 Dec 2008 12:17:57 -0500
Content-Disposition: inline
In-Reply-To: <1229593665.7086.1.camel@localhost>
Sender: linux-next-owner@vger.kernel.org
List-ID: <linux-next.vger.kernel.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, linux-s390@vger.kernel.org, heiko.carstens@de.ibm.com

* Martin Schwidefsky <schwidefsky@de.ibm.com> [2008-12-18 10:47:45]:

> On Wed, 2008-12-17 at 23:47 +0530, Kamalesh Babulal wrote:
> > drivers/s390/cio/device.c: In function 'io_subchannel_register':
> > drivers/s390/cio/device.c:913: error: 'struct device' has no member
> > named 'knode_parent'
> > make[2]: *** [drivers/s390/cio/device.o] Error 1
> > make[1]: *** [drivers/s390/cio] Error 2
> > make: *** [drivers/s390] Error 2
> 
> Should be fixed now by the following patch from Cornelia:
> 
> commit efe46b59567ae999ff7d344170d21f093159ad80
> Author: Cornelia Huck <cornelia.huck@de.ibm.com>
> Date:   Thu Dec 18 10:26:55 2008 +0100
> 
>     [S390] cio: Use device_is_registered().
> 
>     Check if a ccw device is registered via device_is_registered()
>     and not via the old kludge of checking the membership in driver
>     core internal klists.
> 
>     Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>     Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> 
> You'll find the fix in the features branch of git390 which will be
> included in the next linux-next kernel.

Hi Martin,

	Thanks, the patch fixes the build failure.I tested the patch with
today's next (20081218), which also has the same build failure.

> 
> -- 
> blue skies,
>   Martin.
> 
> "Reality continues to ruin my life." - Calvin.
> 
> 

-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.