Re: linux-next: usb tree build failure

[Inaky Perez-Gonzalez <inaky@linux.intel.com>]

On Sunday 21 December 2008, Sam Ravnborg wrote:
> On Mon, Dec 22, 2008 at 01:42:21PM +1100, Stephen Rothwell wrote:
> > (Just cc'ing Sam)
> >
> > On Sun, 21 Dec 2008 17:31:10 -0800 Greg KH <greg@kroah.com> wrote:
> > > On Mon, Dec 22, 2008 at 11:33:35AM +1100, Stephen Rothwell wrote:
> > > > Hi Greg,
> > > >
> > > > Today's linux-next build (x86_64 allmodconfig) failed like this:
> > > >
> > > > x86_64-linux-ld: drivers/net/wimax/built-in.o: No such file: No such
> > > > file or directory
> > > >
> > > > I reverted commit 66aa675719ab82a03a66b75210fd40be6541f8fb ("wimax:
> > > > Makefile, Kconfig and docbook linkage for the stack") just to make
> > > > the build work.
> > >
> > > Inaky, any ideas?  This really looks like a build system error that I
> > > ran into with the staging tree in the past.  I had to add a "dummy"
> > > file to the empty directory to get it to build properly.
> > >
> > > I tried to duplicate the problem with a sample patch, but never could
> > > :(
>
> Incidentally I sent some review comments to said patch yesterday
> but missed this one.
>
> We have:
> diff --git a/drivers/net/wimax/Makefile b/drivers/net/wimax/Makefile
> new file mode 100644
> index 0000000..bda9430
> --- /dev/null
> +++ b/drivers/net/wimax/Makefile
> @@ -0,0 +1,2 @@
> +
> +obj-$(CONFIG_WIMAX_I2400M)	+= i2400m/
>
>
>
> But the problem here is that because we do not even pretend to
> build some files in this dir thus kbuild does not create build-in.o
>
> The fix is a bit ugly but simple. Add a dummy statement to
> the drivers/net/wimax/Makefile like this:
>
> # force kbuild to create built-in.o
> obj- := dummy.o

ops -- ok, I will. I guess I have to add this in all the similar ones, right?

Greg, do you want a new patch series or just another patch on top?



-- 
Inaky