linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: scsi <linux-scsi@vger.kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	kxie@chelsio.com, akpm <akpm@linux-foundation.org>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	jejb <James.Bottomley@hansenpartnership.com>
Subject: [PATCH -next v2] cxgb3i: use same dependencies & selects as CHELSIO_T3
Date: Mon, 29 Dec 2008 13:23:12 -0800	[thread overview]
Message-ID: <20081229132312.10934479.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20081229130110.67d5271a.randy.dunlap@oracle.com>

From: Randy Dunlap <randy.dunlap@oracle.com>

Make the CXGB iSCSI driver (that selects the CXGB net driver) have the same
dependencies as the net driver, since kconfig doesn't do that automatically.
Also make it select INET_LRO & FW_LOADER like the net driver does.

drivers/net/cxgb3/cxgb3_main.c:269: error: implicit declaration of function 'pci_disable_msix'
drivers/net/cxgb3/cxgb3_main.c:272: error: implicit declaration of function 'pci_disable_msi'
drivers/net/cxgb3/cxgb3_main.c:2778: error: array type has incomplete element type
drivers/net/cxgb3/cxgb3_main.c:2781: warning: type defaults to 'int' in declaration of 'type name'
drivers/net/cxgb3/cxgb3_main.c:2781: warning: type defaults to 'int' in declaration of 'type name'
drivers/net/cxgb3/cxgb3_main.c:2781: error: size of array 'type name' is negative
drivers/net/cxgb3/cxgb3_main.c:2784: error: implicit declaration of function 'pci_enable_msix'
drivers/net/cxgb3/cxgb3_main.c:2784: warning: type defaults to 'int' in declaration of 'type name'
drivers/net/cxgb3/cxgb3_main.c:2784: warning: type defaults to 'int' in declaration of 'type name'
drivers/net/cxgb3/cxgb3_main.c:2784: error: size of array 'type name' is negative
drivers/net/cxgb3/cxgb3_main.c:2786: warning: type defaults to 'int' in declaration of 'type name'
drivers/net/cxgb3/cxgb3_main.c:2786: warning: type defaults to 'int' in declaration of 'type name'
drivers/net/cxgb3/cxgb3_main.c:2786: error: size of array 'type name' is negative
drivers/net/cxgb3/cxgb3_main.c:2778: warning: unused variable 'entries'
drivers/net/cxgb3/cxgb3_main.c:3011: error: implicit declaration of function 'pci_enable_msi'

and from a different build:

ERROR: "lro_vlan_hwaccel_receive_frags" [drivers/net/cxgb3/cxgb3.ko] undefined!
ERROR: "lro_receive_frags" [drivers/net/cxgb3/cxgb3.ko] undefined!
ERROR: "lro_receive_skb" [drivers/net/cxgb3/cxgb3.ko] undefined!
ERROR: "lro_vlan_hwaccel_receive_skb" [drivers/net/cxgb3/cxgb3.ko] undefined!
ERROR: "lro_flush_all" [drivers/net/cxgb3/cxgb3.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/scsi/cxgb3i/Kconfig |    3 +++
 1 file changed, 3 insertions(+)

--- linux-next-20081229.orig/drivers/scsi/cxgb3i/Kconfig
+++ linux-next-20081229/drivers/scsi/cxgb3i/Kconfig
@@ -1,6 +1,9 @@
 config SCSI_CXGB3_ISCSI
 	tristate "Chelsio S3xx iSCSI support"
+	depends on PCI && INET
 	select CHELSIO_T3
 	select SCSI_ISCSI_ATTRS
+	select INET_LRO
+	select FW_LOADER
 	---help---
 	This driver supports iSCSI offload for the Chelsio S3 series devices.

  reply	other threads:[~2008-12-29 21:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-29 16:16 linux-next: Tree for December 29 Stephen Rothwell
2008-12-29 20:31 ` linux-next: Tree for December 29 (fcoe) Randy Dunlap
2008-12-29 21:35   ` James Bottomley
2008-12-29 21:45     ` James Bottomley
2008-12-29 22:21       ` Randy Dunlap
2008-12-29 20:35 ` linux-next: Tree for December 29 (cxgb3i) Randy Dunlap
2008-12-29 21:51   ` James Bottomley
2008-12-29 22:10     ` Randy Dunlap
2008-12-29 21:01 ` [PATCH -next] cxgb3i: use same dependencies as CHELSIO_T3 Randy Dunlap
2008-12-29 21:23   ` Randy Dunlap [this message]
2008-12-29 21:58     ` [PATCH -next v2] cxgb3i: use same dependencies & selects " James Bottomley
2008-12-29 22:08       ` Randy Dunlap
2008-12-30 16:20         ` James Bottomley
2008-12-30  3:53 ` linux-next: Tree for December 29 (fcoe/libfc) Randy Dunlap
2008-12-30 15:44   ` James Bottomley
2008-12-30 16:54     ` Randy Dunlap
2008-12-30 17:12       ` James Bottomley
2008-12-30 17:36         ` Randy Dunlap
2008-12-30 17:40         ` Kamalesh Babulal
2008-12-30 15:45 ` [BUILD-FAILURE] fcoe driver build fails with !CONFIG_PCI Kamalesh Babulal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081229132312.10934479.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=kxie@chelsio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).