From: Neil Horman <nhorman@tuxdriver.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Linus <torvalds@linux-foundation.org>,
netdev@vger.kernel.org, ppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] clean up of netif_rx_reschedule() changes in drivers
Date: Mon, 29 Dec 2008 10:37:57 -0500 [thread overview]
Message-ID: <20081229153757.GA2857@localhost.localdomain> (raw)
In-Reply-To: <20081229214144.43be8c1d.sfr@canb.auug.org.au>
On Mon, Dec 29, 2008 at 09:41:44PM +1100, Stephen Rothwell wrote:
> Hi Kamalesh,
>
> On Mon, 29 Dec 2008 15:55:29 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
> >
> > I hit similar build failure due to the change in the netif_rx_reschedule()
> >
> > drivers/net/ehea/ehea_main.c: In function 'ehea_poll':
> > drivers/net/ehea/ehea_main.c:844: warning: passing argument 1 of 'netif_rx_reschedule' from incompatible pointer type
> > drivers/net/ehea/ehea_main.c:844: error: too many arguments to function 'netif_rx_reschedule'
> > make[3]: *** [drivers/net/ehea/ehea_main.o] Error 1
>
> Linus already took a patch for ibmveth and ehea.
>
> > greping through the sources for the changes missed out, we have
> >
> .
> .
> >
> > Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> > --
> > drivers/net/arm/ep93xx_eth.c | 2 +-
> > drivers/net/arm/ixp4xx_eth.c | 2 +-
> > drivers/net/wan/ixp4xx_hss.c | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
>
> Thanks for the patch, I assume that Dave or Linus will take care of that.
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
Thanks guys, not sure how my patch missed that. I did an allmodconfig build
that passed successfully. Thanks!
Acked-by: Neil Horman <nhorman@tuxdriver.com>
next prev parent reply other threads:[~2008-12-29 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 0:00 linux-next: origin tree build failure Stephen Rothwell
2008-12-29 10:25 ` [PATCH] clean up of netif_rx_reschedule() changes in drivers Kamalesh Babulal
2008-12-29 10:41 ` Stephen Rothwell
2008-12-29 15:37 ` Neil Horman [this message]
2008-12-30 2:19 ` David Miller
2008-12-30 16:39 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081229153757.GA2857@localhost.localdomain \
--to=nhorman@tuxdriver.com \
--cc=davem@davemloft.net \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).