From: Greg KH <gregkh@suse.de>
To: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: Steve French <smfrench@gmail.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
sfrench@samba.org
Subject: Re: linux-next: Tree for January 12 (cifs vs. staging)
Date: Mon, 12 Jan 2009 11:23:51 -0800 [thread overview]
Message-ID: <20090112192351.GA7607@suse.de> (raw)
In-Reply-To: <1231787958.6383.18.camel@norville.austin.ibm.com>
On Mon, Jan 12, 2009 at 01:19:18PM -0600, Dave Kleikamp wrote:
> On Mon, 2009-01-12 at 12:58 -0600, Steve French wrote:
> > There is not just the cifs md5 one (which has been around a long
> > time), but an md5_init (static) in crypto and the new one in rt. The
> > addition of the new one (rt md5_init) causes the build problem. It
> > would be nice if we could use the same md5 routines though ... last
> > time we checked the crypto one was not well suited for calculating
> > signatures as a network fs would do though.
>
> Is that due to the byte-swapping? Can the cifs and rt* drivers use the
> same code. rt28[67]0/common/md5.c are identical files. In fact those
> "common" directories should probably be combined into a single truly
> common directory.
Yes, the "common" directories are going to be merged, but as they
originally came from different driver sources, they didn't start out
that way. It will take some refactoring to get it to work properly,
which is on my todo list...
thanks,
greg k-h
next prev parent reply other threads:[~2009-01-12 19:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 4:45 linux-next: Tree for January 12 Stephen Rothwell
2009-01-12 18:19 ` linux-next: Tree for January 12 (cifs vs. staging) Randy Dunlap
2009-01-12 18:58 ` Steve French
2009-01-12 19:13 ` Greg KH
2009-01-12 19:23 ` Steve French
2009-01-12 19:32 ` Greg KH
2009-01-12 20:13 ` Steve French
2009-01-12 20:21 ` Greg KH
2009-01-12 20:40 ` Steve French
2009-01-12 21:07 ` Steve French
2009-01-13 2:01 ` Valdis.Kletnieks
2009-01-13 2:27 ` Dave Kleikamp
2009-01-13 2:35 ` Valdis.Kletnieks
2009-01-12 19:19 ` Dave Kleikamp
2009-01-12 19:23 ` Greg KH [this message]
2009-01-12 19:35 ` Steve French
2009-01-12 18:50 ` [PATCH -next] libfc: needs CRC32 Randy Dunlap
2009-01-13 0:05 ` Love, Robert W
2009-01-12 18:53 ` [PATCH -next] scsi_debug: needs CRC_T10DIF Randy Dunlap
2009-01-13 3:26 ` Martin K. Petersen
2009-01-12 19:08 ` linux-next: Tree for January 12 (afs/fscache) Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2009-01-13 6:35 linux-next: Tree for January 12 (cifs vs. staging) Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090112192351.GA7607@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
--cc=sfrench@samba.org \
--cc=shaggy@linux.vnet.ibm.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).