From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Mike Frysinger <vapier.adi@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"Sachin P. Sant" <sachinp@in.ibm.com>,
linux-s390@vger.kernel.org, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com
Subject: Re: [s390] next Feb 18: defconfig build break
Date: Thu, 19 Feb 2009 09:51:50 +0000 [thread overview]
Message-ID: <20090219095150.GA5808@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200902191045.25878.rusty@rustcorp.com.au>
On Thu, Feb 19, 2009 at 10:45:25AM +1030, Rusty Russell wrote:
> Subject: arm: allow usage of string functions in linux/string.h
>
> In introducing a trivial "strstarts()" function in linux/string.h, we
> hit:
>
> arch/arm/boot/compressed/misc.o: In function `strstarts':
> misc.c:(.text+0x368): undefined reference to `strlen'
> misc.c:(.text+0x378): undefined reference to `strncmp'
>
> This is because of "CFLAGS_misc.o := -Dstatic=" in the Makefile.
> "static inline strstarts(...)" becomes non-inline, and refers to the
> other string ops.
>
> The simplest workaround is to include asm/string.h. This makes sense
> anyway, since lib/string.c won't be linked against this so we can't
> use those functions anyway.
>
> Compile tested here.
>
> Reported-by: linux-next
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
I guess this should go in with the change which caused the breakage.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2009-02-19 9:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 8:16 linux-next: Tree for February 18 Stephen Rothwell
2009-02-18 10:29 ` [s390] next Feb 18: defconfig build break Sachin P. Sant
2009-02-18 11:45 ` Stephen Rothwell
2009-02-18 17:10 ` Mike Frysinger
2009-02-18 22:43 ` Rusty Russell
2009-02-19 5:20 ` Sachin P. Sant
2009-02-20 10:23 ` Martin Schwidefsky
2009-02-18 22:59 ` Rusty Russell
2009-02-19 1:55 ` Mike Frysinger
2009-02-19 11:40 ` Rusty Russell
2009-02-19 17:14 ` Mike Frysinger
2009-02-19 0:15 ` Rusty Russell
2009-02-19 9:51 ` Russell King [this message]
2009-02-19 11:48 ` Rusty Russell
2009-02-18 18:02 ` [PATCH] module: fix build for CONFIG_SYSFS=n Randy Dunlap
2009-02-18 18:09 ` Ingo Molnar
2009-02-18 18:35 ` [PATCH v2] " Randy Dunlap
2009-02-18 19:15 ` Ingo Molnar
2009-02-19 10:50 ` Rusty Russell
2009-02-19 7:32 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090219095150.GA5808@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sachinp@in.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).