From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King Subject: Re: [s390] next Feb 18: defconfig build break Date: Thu, 19 Feb 2009 09:51:50 +0000 Message-ID: <20090219095150.GA5808@flint.arm.linux.org.uk> References: <20090218191640.0b023029.sfr@canb.auug.org.au> <20090218224541.fe6e0355.sfr@canb.auug.org.au> <8bd0f97a0902180910wafd35ceo47aeb9f3cc6733f3@mail.gmail.com> <200902191045.25878.rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:45898 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754047AbZBSJwe (ORCPT ); Thu, 19 Feb 2009 04:52:34 -0500 Content-Disposition: inline In-Reply-To: <200902191045.25878.rusty@rustcorp.com.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Rusty Russell Cc: Mike Frysinger , Stephen Rothwell , "Sachin P. Sant" , linux-s390@vger.kernel.org, linux-next@vger.kernel.org, LKML , schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com On Thu, Feb 19, 2009 at 10:45:25AM +1030, Rusty Russell wrote: > Subject: arm: allow usage of string functions in linux/string.h > > In introducing a trivial "strstarts()" function in linux/string.h, we > hit: > > arch/arm/boot/compressed/misc.o: In function `strstarts': > misc.c:(.text+0x368): undefined reference to `strlen' > misc.c:(.text+0x378): undefined reference to `strncmp' > > This is because of "CFLAGS_misc.o := -Dstatic=" in the Makefile. > "static inline strstarts(...)" becomes non-inline, and refers to the > other string ops. > > The simplest workaround is to include asm/string.h. This makes sense > anyway, since lib/string.c won't be linked against this so we can't > use those functions anyway. > > Compile tested here. > > Reported-by: linux-next > Signed-off-by: Rusty Russell Acked-by: Russell King I guess this should go in with the change which caused the breakage. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: