From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Schwidefsky Subject: Re: [s390] next Feb 18: defconfig build break Date: Fri, 20 Feb 2009 11:23:39 +0100 Message-ID: <20090220112339.7fd84556@de.ibm.com> References: <20090218191640.0b023029.sfr@canb.auug.org.au> <20090218224541.fe6e0355.sfr@canb.auug.org.au> <8bd0f97a0902180910wafd35ceo47aeb9f3cc6733f3@mail.gmail.com> <200902190913.27653.rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mtagate4.de.ibm.com ([195.212.29.153]:36412 "EHLO mtagate4.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753845AbZBTKXt (ORCPT ); Fri, 20 Feb 2009 05:23:49 -0500 In-Reply-To: <200902190913.27653.rusty@rustcorp.com.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Rusty Russell Cc: Mike Frysinger , Stephen Rothwell , "Sachin P. Sant" , linux-s390@vger.kernel.org, linux-next@vger.kernel.org, LKML , heiko.carstens@de.ibm.com Hi Rusty, On Thu, 19 Feb 2009 09:13:26 +1030 Rusty Russell wrote: > Here's the s390 fix: > > Subject: s390: allow usage of string functions in linux/string.h Thanks for the fix. > Because when including asm/string.h from arch/s390/lib/string.c we > don't declare the string ops we are about to define, and > linux/string.h barfs. > > The fix is to declare them in this IN_ARCH_STRING_C case, but in > general I wonder if there's a neater fix. The out-of-line version of the string functions in arch/s390/lib/string.c needs EXPORT_SYMBOL and other stuff. To fix the problem without the seperate out-of-line prototypes would required to avoid the inclusing of linux/string.h. Which would be fragile if possible at all. So I think your patch is the best way to deal with the problem. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.