From: Ingo Molnar <mingo@elte.hu>
To: Tejun Heo <tj@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-next@vger.kernel.org,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: linux-next: tracing tree build failure
Date: Tue, 10 Mar 2009 10:10:10 +0100 [thread overview]
Message-ID: <20090310091010.GD3097@elte.hu> (raw)
In-Reply-To: <49B5C733.6080005@kernel.org>
* Tejun Heo <tj@kernel.org> wrote:
> Stephen Rothwell wrote:
> > Hi all,
> >
> > Today's linux-next build (x86_64 allmodconfig) failed like this:
> >
> > kernel/trace/trace_functions_graph.c: In function 'graph_trace_close':
> > kernel/trace/trace_functions_graph.c:836: error: implicit declaration of function 'percpu_free'
> >
> > The direct cause is commit 422d3c7a577b15e1384c9d4e72a9540896b685fa
> > ("tracing: current tip/master can't enable ftrace") from the tracing tree
> > which exposed an interaction between commit
> > f2a8205c4ef1af917d175c36a4097ae5587791c8 ("percpu: kill percpu_alloc()
> > and friends") from the tip-core tree and commit
> > 9005f3ebebfcfe9ccd731d16c468907a35ac1f9a ("tracing/function-graph-tracer:
> > various fixes and features") from the tracing tree.
> >
> > I have reverted commit 422d3c7a577b15e1384c9d4e72a9540896b685fa for
> > today. (As a side note, that commit has no Signed-off-by ...)
>
> Just in case someone doesn't know yet. The remedy is using
> free_percpu() instead of percpu_free().
That's exactly how it was resolved more than two weeks ago in
tip:master - and has been resolved in tip:master since then.
I'm glad to hear about new bugs, but the amount of false
positives from linux-next is wasting a lot of time - the
duplication rate is above 90% which is way too much.
tip:master is a full, well-tested integration of all those
branches. It would be nice if Stephen investigated tip:master
before reporting such solved-long-ago interactions.
Ingo
next prev parent reply other threads:[~2009-03-10 9:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 0:55 linux-next: tracing tree build failure Stephen Rothwell
2009-03-10 1:49 ` Tejun Heo
2009-03-10 9:10 ` Ingo Molnar [this message]
2009-03-10 2:16 ` KOSAKI Motohiro
-- strict thread matches above, loose matches on Subject: below --
2009-03-26 1:14 Stephen Rothwell
2009-03-26 1:37 ` Masami Hiramatsu
2009-03-26 7:54 ` Ingo Molnar
2009-03-26 8:04 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090310091010.GD3097@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).