linux-next: tracing tree build failure

linux-next: tracing tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

Hi all,

Today's linux-next build (x86_64 allmodconfig) failed like this:

kernel/trace/trace_functions_graph.c: In function 'graph_trace_close':
kernel/trace/trace_functions_graph.c:836: error: implicit declaration of function 'percpu_free'

The direct cause is commit 422d3c7a577b15e1384c9d4e72a9540896b685fa
("tracing: current tip/master can't enable ftrace") from the tracing tree
which exposed an interaction between commit
f2a8205c4ef1af917d175c36a4097ae5587791c8 ("percpu: kill percpu_alloc()
and friends") from the tip-core tree and commit
9005f3ebebfcfe9ccd731d16c468907a35ac1f9a ("tracing/function-graph-tracer:
various fixes and features") from the tracing tree.

I have reverted commit 422d3c7a577b15e1384c9d4e72a9540896b685fa for
today.  (As a side note, that commit has no Signed-off-by ...)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: tracing tree build failure

[Tejun Heo]

Stephen Rothwell wrote:
> Hi all,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> kernel/trace/trace_functions_graph.c: In function 'graph_trace_close':
> kernel/trace/trace_functions_graph.c:836: error: implicit declaration of function 'percpu_free'
> 
> The direct cause is commit 422d3c7a577b15e1384c9d4e72a9540896b685fa
> ("tracing: current tip/master can't enable ftrace") from the tracing tree
> which exposed an interaction between commit
> f2a8205c4ef1af917d175c36a4097ae5587791c8 ("percpu: kill percpu_alloc()
> and friends") from the tip-core tree and commit
> 9005f3ebebfcfe9ccd731d16c468907a35ac1f9a ("tracing/function-graph-tracer:
> various fixes and features") from the tracing tree.
> 
> I have reverted commit 422d3c7a577b15e1384c9d4e72a9540896b685fa for
> today.  (As a side note, that commit has no Signed-off-by ...)

Just in case someone doesn't know yet.  The remedy is using
free_percpu() instead of percpu_free().

Thanks.

-- 
tejun

Re: linux-next: tracing tree build failure

[Ingo Molnar]

* Tejun Heo <tj@kernel.org> wrote:

> Stephen Rothwell wrote:
> > Hi all,
> > 
> > Today's linux-next build (x86_64 allmodconfig) failed like this:
> > 
> > kernel/trace/trace_functions_graph.c: In function 'graph_trace_close':
> > kernel/trace/trace_functions_graph.c:836: error: implicit declaration of function 'percpu_free'
> > 
> > The direct cause is commit 422d3c7a577b15e1384c9d4e72a9540896b685fa
> > ("tracing: current tip/master can't enable ftrace") from the tracing tree
> > which exposed an interaction between commit
> > f2a8205c4ef1af917d175c36a4097ae5587791c8 ("percpu: kill percpu_alloc()
> > and friends") from the tip-core tree and commit
> > 9005f3ebebfcfe9ccd731d16c468907a35ac1f9a ("tracing/function-graph-tracer:
> > various fixes and features") from the tracing tree.
> > 
> > I have reverted commit 422d3c7a577b15e1384c9d4e72a9540896b685fa for
> > today.  (As a side note, that commit has no Signed-off-by ...)
> 
> Just in case someone doesn't know yet.  The remedy is using
> free_percpu() instead of percpu_free().

That's exactly how it was resolved more than two weeks ago in 
tip:master - and has been resolved in tip:master since then.

I'm glad to hear about new bugs, but the amount of false 
positives from linux-next is wasting a lot of time - the 
duplication rate is above 90% which is way too much.

tip:master is a full, well-tested integration of all those 
branches. It would be nice if Stephen investigated tip:master 
before reporting such solved-long-ago interactions.

	Ingo

Re: linux-next: tracing tree build failure

[KOSAKI Motohiro]

Hi Stephen,

> Hi all,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> kernel/trace/trace_functions_graph.c: In function 'graph_trace_close':
> kernel/trace/trace_functions_graph.c:836: error: implicit declaration of function 'percpu_free'
> 
> The direct cause is commit 422d3c7a577b15e1384c9d4e72a9540896b685fa
> ("tracing: current tip/master can't enable ftrace") from the tracing tree
> which exposed an interaction between commit
> f2a8205c4ef1af917d175c36a4097ae5587791c8 ("percpu: kill percpu_alloc()
> and friends") from the tip-core tree and commit
> 9005f3ebebfcfe9ccd731d16c468907a35ac1f9a ("tracing/function-graph-tracer:
> various fixes and features") from the tracing tree.
> 
> I have reverted commit 422d3c7a577b15e1384c9d4e72a9540896b685fa for
> today.  (As a side note, that commit has no Signed-off-by ...)

I checked latest -tip tree and I found Ingo fixed this issue by following commit.
Could you please try to pull latest tip tree?


commit 56bc29b4b8e188275f52cd5270bcf54f22cfc92b
Author: Ingo Molnar <mingo@elte.hu>
Date:   Thu Mar 5 22:04:39 2009 +0100

    merge conflict resolutions

linux-next: tracing tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

Hi all,

Today's linux-next build (x86_64 allmodconfig) failed like this:

arch/x86/kernel/kprobes.c: In function 'trampoline_handler':
arch/x86/kernel/kprobes.c:697: error: 'struct pt_regs' has no member named 'gs'

Caused by commit b9dad0d2955db059cd92c81c37ddcbef0abc8bf8 ("x86:
kretprobe-booster interrupt emulation code fix").  64bit appears to not
have a gs in its pt_regs.

I have used the version of this tree that was in next-20090325 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: tracing tree build failure

[Masami Hiramatsu]

Hi Stephen,

Stephen Rothwell wrote:
> Hi all,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> arch/x86/kernel/kprobes.c: In function 'trampoline_handler':
> arch/x86/kernel/kprobes.c:697: error: 'struct pt_regs' has no member named 'gs'
> 
> Caused by commit b9dad0d2955db059cd92c81c37ddcbef0abc8bf8 ("x86:
> kretprobe-booster interrupt emulation code fix").  64bit appears to not
> have a gs in its pt_regs.

Oh, that was fixed on linux-2.6-tip tree...

http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commit;h=fee039a1d05c6e0f71b0fe270d847742a02d56c4

> 
> I have used the version of this tree that was in next-20090325 for today.

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com

Re: linux-next: tracing tree build failure

[Ingo Molnar]

* Masami Hiramatsu <mhiramat@redhat.com> wrote:

> Hi Stephen,
> 
> Stephen Rothwell wrote:
> > Hi all,
> > 
> > Today's linux-next build (x86_64 allmodconfig) failed like this:
> > 
> > arch/x86/kernel/kprobes.c: In function 'trampoline_handler':
> > arch/x86/kernel/kprobes.c:697: error: 'struct pt_regs' has no member named 'gs'
> > 
> > Caused by commit b9dad0d2955db059cd92c81c37ddcbef0abc8bf8 ("x86:
> > kretprobe-booster interrupt emulation code fix").  64bit appears to not
> > have a gs in its pt_regs.
> 
> Oh, that was fixed on linux-2.6-tip tree...
> 
> http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commit;h=fee039a1d05c6e0f71b0fe270d847742a02d56c4

I have pushed out a new tree for linux-next, to pick up this fix.

	Ingo

Re: linux-next: tracing tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

Hi Ingo,

On Thu, 26 Mar 2009 08:54:10 +0100 Ingo Molnar <mingo@elte.hu> wrote:
>
> I have pushed out a new tree for linux-next, to pick up this fix.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]