From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH next-20090316] sunrpc: fix build breakage Date: Wed, 18 Mar 2009 08:56:28 -0700 Message-ID: <20090318085628.36eea73c.randy.dunlap@oracle.com> References: <20090316125140.GA3095@orion> <1237208680.7229.14.camel@heimdal.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1237208680.7229.14.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Trond Myklebust Cc: Alexander Beregalov , linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-next.vger.kernel.org On Mon, 16 Mar 2009 09:04:40 -0400 Trond Myklebust wrote: > On Mon, 2009-03-16 at 15:51 +0300, Alexander Beregalov wrote: > > net/sunrpc/clnt.c: In function 'call_bind_status': > > net/sunrpc/clnt.c:994: error: 'struct rpc_task' has no member named > > 'tk_pid' > > net/sunrpc/clnt.c: In function 'call_connect_status': > > net/sunrpc/clnt.c:1051: error: 'struct rpc_task' has no member named > > 'tk_pid' > > > > rpc_task has tk_pid if RPC_DEBUG is defined. > > > > Signed-off-by: Alexander Beregalov > > --- > > > > net/sunrpc/clnt.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c > > index efd0c7b..68cb91a 100644 > > --- a/net/sunrpc/clnt.c > > +++ b/net/sunrpc/clnt.c > > @@ -990,7 +990,7 @@ call_bind_status(struct rpc_task *task) > > return; > > default: > > if (net_ratelimit()) > > - printk("RPC: %5u unrecognized rpcbind error (%d)\n", > > + dprintk("RPC: %5u unrecognized rpcbind error (%d)\n", > > task->tk_pid, -task->tk_status); > > } > > > > @@ -1047,7 +1047,7 @@ call_connect_status(struct rpc_task *task) > > break; > > default: > > if (net_ratelimit()) > > - printk("RPC: %5u unrecognized connect error (%d)\n", > > + dprintk("RPC: %5u unrecognized connect error (%d)\n", > > task->tk_pid, status); > > rpc_exit(task, -EIO); > > } > > No, that's not right. The intention is to always report errors that are > fatal and are due to unforeseen circumstances. Your patch means that > those reports are suppressed entirely when RPC_DEBUG is undefined. nevertheless, the build breakage is still around in linux-next 20090318... --- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html