From: Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
To: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: linux-next: Tree for March 19 (wireless/p54)
Date: Thu, 19 Mar 2009 18:50:17 +0100 [thread overview]
Message-ID: <200903191850.17825.mb@bu3sch.de> (raw)
In-Reply-To: <49C280BE.8090106-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
On Thursday 19 March 2009 18:28:30 Randy Dunlap wrote:
> Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20090318:
>
>
> ERROR: "led_classdev_register" [drivers/net/wireless/p54/p54common.ko] undefined!
> ERROR: "led_classdev_unregister" [drivers/net/wireless/p54/p54common.ko] undefined!
>
> One possible option (fix) is to have CONFIG_MAC80211_LEDS also select
> LEDS_CLASS (that would build the missing functions).
Does p54 select CONFIG_MAC80211_LEDS? If that's the case, I think it should
probably do it the other way around. p54 should build its LED code if CONFIG_MAC80211_LEDS
is available. Otherwise it should not.
This way you don't enter the SELECT dependency hell and still have automagic configuration.
Take a look at b43 for an example.
--
Greetings, Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-03-19 17:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 11:10 linux-next: Tree for March 19 Stephen Rothwell
2009-03-19 13:20 ` Next March 19: drivers/comedi build break Sachin Sant
2009-03-19 15:33 ` Greg KH
2009-03-19 18:51 ` Greg KH
2009-03-19 16:54 ` linux-next: Tree for March 19 (media/video/au0828) Randy Dunlap
2009-03-19 22:28 ` Mauro Carvalho Chehab
2009-03-19 17:07 ` linux-next: Tree for March 19 (staging/psb) Randy Dunlap
2009-03-19 18:51 ` Greg KH
2009-03-19 17:11 ` linux-next: Tree for March 19 (media/au8522) Randy Dunlap
2009-03-20 0:06 ` Mauro Carvalho Chehab
2009-03-19 17:13 ` linux-next: Tree for March 19 (media/video/cx231xx/) Randy Dunlap
2009-03-19 17:28 ` linux-next: Tree for March 19 (wireless/p54) Randy Dunlap
[not found] ` <49C280BE.8090106-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-03-19 17:50 ` Michael Buesch [this message]
2009-03-19 18:49 ` Randy Dunlap
2009-03-19 18:55 ` Michael Buesch
[not found] ` <200903191955.00718.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2009-03-20 23:57 ` [PATCH] p54: fix SoftLED compile dependencies Christian Lamparter
2009-03-21 6:36 ` Kalle Valo
2009-03-21 12:22 ` Christian Lamparter
[not found] ` <200903211322.01654.chunkeey-S0/GAf8tV78@public.gmane.org>
2009-03-21 12:27 ` Kalle Valo
[not found] ` <873ad7dpru.fsf-4yk3W8r0N7SEazanehQPrg@public.gmane.org>
2009-03-21 15:26 ` Larry Finger
2009-03-23 14:13 ` John W. Linville
[not found] ` <20090323141320.GC3285-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2009-03-23 14:37 ` [PATCH v2] " Christian Lamparter
2009-03-23 1:00 ` [PATCH] " Randy Dunlap
2009-03-23 14:14 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903191850.17825.mb@bu3sch.de \
--to=mb-fseuscv1ubazqb+pc5nmwq@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).