public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, Matthew Wilcox <willy@linux.intel.com>
Subject: Re: linux-next: pci tree build failure
Date: Tue, 24 Mar 2009 18:38:00 -0700	[thread overview]
Message-ID: <20090324183800.6ba50715@hobbes.virtuouswap> (raw)
In-Reply-To: <20090325122121.225a0ccb.sfr@canb.auug.org.au>

On Wed, 25 Mar 2009 12:21:21 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Jesse,
> 
> On Mon, 23 Mar 2009 12:49:48 +1100 Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> >
> > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> > 
> > arch/powerpc/kernel/msi.c: In function 'arch_msi_check_device':
> > arch/powerpc/kernel/msi.c:23: error: 'PCI_CAP_ID_MSI' undeclared
> > (first use in this function)
> > 
> > Caused by commit 1c8d7b0a562da06d3ebe83f01b1ed553205d1ae4 ("PCI
> > MSI: Add support for multiple MSI").  PCI_CAP_ID_MSI is defined in
> > linux/pci_regs.h which is included by linux/pci.h, but neither is
> > included by arch/powerpc/kernel/msi.c.
> > 
> > I have used the version of the pci tree from next-20090320 for
> > today.
> 
> This is still happening ...

Does this fix it?  Some header file changes must be to blame...

diff --git a/arch/powerpc/kernel/msi.c b/arch/powerpc/kernel/msi.c
index 0c16e2a..8bbc12d 100644
--- a/arch/powerpc/kernel/msi.c
+++ b/arch/powerpc/kernel/msi.c
@@ -9,6 +9,7 @@

 #include <linux/kernel.h>
 #include <linux/msi.h>
+#include <linux/pci.h>

 #include <asm/machdep.h>



-- 
Jesse Barnes, Intel Open Source Technology Center

  reply	other threads:[~2009-03-25  1:44 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-23  1:49 linux-next: pci tree build failure Stephen Rothwell
2009-03-25  1:21 ` Stephen Rothwell
2009-03-25  1:38   ` Jesse Barnes [this message]
2009-03-25  3:41     ` Stephen Rothwell
2009-03-25  4:30       ` Matthew Wilcox
2009-03-25 15:55         ` Jesse Barnes
2009-03-26  3:05           ` Stephen Rothwell
2009-03-26  3:37             ` Jesse Barnes
2009-03-26  4:54               ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2010-01-27  6:49 Stephen Rothwell
2010-01-27 17:31 ` Jesse Barnes
2010-01-28  6:14   ` Stephen Rothwell
2010-01-18  8:40 Stephen Rothwell
2010-01-18 21:24 ` Rafael J. Wysocki
2010-01-19  2:35   ` Jesse Barnes
2010-01-19  3:19     ` Stephen Rothwell
2010-01-20  4:39 ` Jesse Barnes
2010-01-20  5:19   ` Stephen Rothwell
2010-01-04 22:55 Stephen Rothwell
2010-01-04 23:10 ` Matthew Wilcox
2010-01-04 23:48   ` Jesse Barnes
2010-01-05  3:41     ` Stephen Rothwell
2009-10-07  1:38 Stephen Rothwell
2009-10-07  1:45 ` Tejun Heo
2009-10-07 15:39   ` Jesse Barnes
2009-07-15  1:45 Stephen Rothwell
2009-07-15 16:09 ` Jesse Barnes
2009-07-15 23:46   ` Stephen Rothwell
2009-06-30  2:07 Stephen Rothwell
2009-06-30  2:13 ` Jesse Barnes
2009-06-30  2:24   ` Matthew Wilcox
2009-06-30 20:31     ` Jesse Barnes
2008-10-22  2:39 Stephen Rothwell
2008-10-22  3:47 ` Jesse Barnes
2008-10-16  3:41 Stephen Rothwell
2008-10-16  3:44 ` Benjamin Herrenschmidt
2008-10-16  4:23   ` Jesse Barnes
2008-10-16  4:28     ` Benjamin Herrenschmidt
2008-10-18 22:41       ` Jesse Barnes
2008-10-19  4:15         ` Stephen Rothwell
2008-10-19  4:30           ` Jesse Barnes
     [not found] <20080717130924.edd5a501.sfr@canb.auug.org.au>
2008-07-17 22:57 ` Rafael J. Wysocki
2008-07-18  6:09   ` Stephen Rothwell
2008-07-18  7:53     ` Ingo Molnar
2008-07-08  1:40 Stephen Rothwell
2008-07-08 14:54 ` Rafael J. Wysocki
     [not found] <20080630142314.34654d3c.sfr@canb.auug.org.au>
2008-06-30 14:11 ` Alan Stern
2008-07-02  2:11   ` Jesse Barnes
2008-06-30  5:11 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090324183800.6ba50715@hobbes.virtuouswap \
    --to=jbarnes@virtuousgeek.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox