From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Carstens Subject: Re: Next March 27 : s390 defconfig build failure Date: Fri, 27 Mar 2009 15:40:27 +0100 Message-ID: <20090327154027.55afeb02@osiris.boeblingen.de.ibm.com> References: <20090327231924.4e4168c5.sfr@canb.auug.org.au> <49CCDB30.7010203@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mtagate4.uk.ibm.com ([195.212.29.137]:63893 "EHLO mtagate4.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754803AbZC0Okc (ORCPT ); Fri, 27 Mar 2009 10:40:32 -0400 In-Reply-To: <49CCDB30.7010203@in.ibm.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Sachin Sant , Ingo Molnar Cc: linux-s390@vger.kernel.org, Stephen Rothwell , linux-next@vger.kernel.org, Martin Schwidefsky On Fri, 27 Mar 2009 19:27:04 +0530 Sachin Sant wrote: > Today's Next defconfig s390 build failed with > > arch/s390/hypfs/hypfs_diag.c: In function diag204_free_buffer: > arch/s390/hypfs/hypfs_diag.c:364: error: implicit declaration of function free_pages > arch/s390/hypfs/hypfs_diag.c: In function diag204_alloc_rbuf: > arch/s390/hypfs/hypfs_diag.c:384: error: implicit declaration of function __get_free_pages > arch/s390/hypfs/hypfs_diag.c:384: error: GFP_KERNEL undeclared (first use in this function) Thanks for reporting. Ingo, could you pick up the patch below please? Subject: [PATCH] s390/hypfs: fix build breakage From: Heiko Carstens Fix build breakage below which probably was introduced with ("rcu: don't include unnecessary headers, allow kmemtrace w/ tracepoints"). CC arch/s390/hypfs/hypfs_diag.o arch/s390/hypfs/hypfs_diag.c: In function 'diag204_free_buffer': arch/s390/hypfs/hypfs_diag.c:364: error: implicit declaration of function 'free_pages' arch/s390/hypfs/hypfs_diag.c: In function 'diag204_alloc_rbuf': arch/s390/hypfs/hypfs_diag.c:384: error: implicit declaration of function '__get_free_pages' arch/s390/hypfs/hypfs_diag.c:384: error: 'GFP_KERNEL' undeclared (first use in this function) arch/s390/hypfs/hypfs_diag.c:384: error: (Each undeclared identifier is reported only once arch/s390/hypfs/hypfs_diag.c:384: error: for each function it appears in.) Reported-by: Sachin Sant Signed-off-by: Heiko Carstens --- arch/s390/hypfs/hypfs_diag.c | 2 ++ 1 file changed, 2 insertions(+) Index: linux-next/arch/s390/hypfs/hypfs_diag.c =================================================================== --- linux-next.orig/arch/s390/hypfs/hypfs_diag.c +++ linux-next/arch/s390/hypfs/hypfs_diag.c @@ -12,6 +12,8 @@ #include #include +#include +#include #include #include #include