From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Paul Mackerras <paulus@samba.org>
Cc: subrata@linux.vnet.ibm.com,
Linuxppc-dev <Linuxppc-dev@ozlabs.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Stefan Bader <stefan.bader@canonical.com>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Adrian Bunk <bunk@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next <linux-next@vger.kernel.org>,
sachinp <sachinp@linux.vnet.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Alexander Beregalov <a.beregalov@gmail.com>
Subject: Re: [BUILD FAILURE 05/12] Next April 21 : PPC64 randconfig [drivers/macintosh/mediabay.o]
Date: Wed, 22 Apr 2009 11:34:17 +0200 [thread overview]
Message-ID: <200904221134.18163.bzolnier@gmail.com> (raw)
In-Reply-To: <18926.38431.910952.630575@cargo.ozlabs.ibm.com>
On Wednesday 22 April 2009 05:59:27 Paul Mackerras wrote:
> Bartlomiej Zolnierkiewicz writes:
>
> > mediabay shouldn't include <linux/ide.h> unconditionally so
> > remove the superfluous include from mediabay.c (<asm/mediabay.h>
> > will pull <linux/ide.h> in for CONFIG_BLK_DEV_IDE_PMAC=y).
>
> I don't like relying on second-hand imports like that. I prefer the
> previous patch, that made mediabay depend on CONFIG_BLOCK.
I missed it somehow...
OK, I found it now and it should fix the problem as well.
> BTW, if including <linux/ide.h> causes an error when CONFIG_BLOCK=n,
> then there is a bug in <linux/ide.h>, IMO.
<linux/ide.h> is for drivers/ide only. mediabay lacks proper abstraction
layer and is probably the only abuser left.
Besides being a build fix my patch is a right step in cleaning this mess
so I'm going to apply it through ide tree.
Thanks,
Bart
prev parent reply other threads:[~2009-04-22 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 18:51 [BUILD FAILURE 05/12] Next April 21 : PPC64 randconfig [drivers/macintosh/mediabay.o] Subrata Modak
2009-04-21 19:04 ` Bartlomiej Zolnierkiewicz
2009-04-22 3:59 ` Paul Mackerras
2009-04-22 9:34 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904221134.18163.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=Linuxppc-dev@ozlabs.org \
--cc=a.beregalov@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=paulus@samba.org \
--cc=sachinp@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=stefan.bader@canonical.com \
--cc=subrata@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).