linux-next: wireless-current tree build failure

linux-next: wireless-current tree build failure

[Stephen Rothwell]

Hi John,

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/net/wireless/iwlwifi/iwl3945-base.c:1415: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict

I am pretty sure that this is a compiler bug, so not to worry.  However,
as far as I can see, iwl-3945.o (the only user) and iwl3945-base.o are
always linked into the same module, so the EXPORT_SYMBOL (which causes
the problem) should not be needed.  Correct?

I applied the following patch for today.  This makes the above error go
away and my x86_64 allmodconfig still builds.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 22 Apr 2009 15:11:05 +1000
Subject: [PATCH] wireless: remove unneeded EXPORT_SYMBOL the tickles a powerpc compiler bug

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/wireless/iwlwifi/iwl3945-base.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index 9c0779d..da2b3d1 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -1412,7 +1412,6 @@ void iwl3945_rx_queue_reset(struct iwl_priv *priv, struct iwl_rx_queue *rxq)
 	rxq->free_count = 0;
 	spin_unlock_irqrestore(&rxq->lock, flags);
 }
-EXPORT_SYMBOL(iwl3945_rx_queue_reset);
 
 /*
  * this should be called while priv->lock is locked
-- 
1.6.2.3

Re: linux-next: wireless-current tree build failure

[John W. Linville]

On Wed, Apr 22, 2009 at 03:19:28PM +1000, Stephen Rothwell wrote:
> Hi John,
> 
> Today's linux-next build (powerpc allyesconfig) failed like this:
> 
> drivers/net/wireless/iwlwifi/iwl3945-base.c:1415: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
> 
> I am pretty sure that this is a compiler bug, so not to worry.  However,
> as far as I can see, iwl-3945.o (the only user) and iwl3945-base.o are
> always linked into the same module, so the EXPORT_SYMBOL (which causes
> the problem) should not be needed.  Correct?
> 
> I applied the following patch for today.  This makes the above error go
> away and my x86_64 allmodconfig still builds.

Seems reasonable.  Reinette, should I just take Stephen's patch?
Or would you prefer some other solution?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: linux-next: wireless-current tree build failure

[reinette chatre]

Hi John,

On Wed, 2009-04-22 at 06:03 -0700, John W. Linville wrote:
> On Wed, Apr 22, 2009 at 03:19:28PM +1000, Stephen Rothwell wrote:
> > Hi John,
> > 
> > Today's linux-next build (powerpc allyesconfig) failed like this:
> > 
> > drivers/net/wireless/iwlwifi/iwl3945-base.c:1415: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
> > 
> > I am pretty sure that this is a compiler bug, so not to worry.  However,
> > as far as I can see, iwl-3945.o (the only user) and iwl3945-base.o are
> > always linked into the same module, so the EXPORT_SYMBOL (which causes
> > the problem) should not be needed.  Correct?
> > 
> > I applied the following patch for today.  This makes the above error go
> > away and my x86_64 allmodconfig still builds.
> 
> Seems reasonable.  Reinette, should I just take Stephen's patch?
> Or would you prefer some other solution?

This patch looks good. I did ack a duplicate patch from Johannes, but
Stephen was first with this solution. You can choose which one you want
to merge.

Acked-by: Reinette Chatre <reinette.chatre@intel.com>

Thank you

Reinette

linux-next: wireless-current tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

Hi John,

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/net/wireless/ath9k/hw.c: In function 'ath9k_hw_9280_spur_mitigate':
drivers/net/wireless/ath9k/hw.c:4660: internal compiler error: in expand_expr_real_1, at expr.c:9199

Clearly not our fault! :-) I have informed our toolchain person.  This
was using the Debian gcc-4.3.  It also fails using the Debian 4.2
compiler but not the 4.1 one.

For now, I will apply the following patch to just stop it building on
PowerPC.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: wireless-current tree build failure

[Adrian Bunk]

On Tue, Aug 05, 2008 at 04:21:52PM +1000, Stephen Rothwell wrote:
> Hi John,
> 
> Today's linux-next build (powerpc allyesconfig) failed like this:
> 
> drivers/net/wireless/ath9k/hw.c: In function 'ath9k_hw_9280_spur_mitigate':
> drivers/net/wireless/ath9k/hw.c:4660: internal compiler error: in expand_expr_real_1, at expr.c:9199
> 
> Clearly not our fault! :-) I have informed our toolchain person.  This
> was using the Debian gcc-4.3.  It also fails using the Debian 4.2
> compiler but not the 4.1 one.
>...

Alexandros Couloumbis already opened a bug for this issue on mips, which 
also seems to be affected:
  http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37014

It is a gcc bug, but we'll have to work around it in the ath9k driver.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: linux-next: wireless-current tree build failure

[John W. Linville]

On Tue, Aug 05, 2008 at 06:37:57PM +0300, Adrian Bunk wrote:
> On Tue, Aug 05, 2008 at 04:21:52PM +1000, Stephen Rothwell wrote:
> > Hi John,
> > 
> > Today's linux-next build (powerpc allyesconfig) failed like this:
> > 
> > drivers/net/wireless/ath9k/hw.c: In function 'ath9k_hw_9280_spur_mitigate':
> > drivers/net/wireless/ath9k/hw.c:4660: internal compiler error: in expand_expr_real_1, at expr.c:9199
> > 
> > Clearly not our fault! :-) I have informed our toolchain person.  This
> > was using the Debian gcc-4.3.  It also fails using the Debian 4.2
> > compiler but not the 4.1 one.
> >...
> 
> Alexandros Couloumbis already opened a bug for this issue on mips, which 
> also seems to be affected:
>   http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37014
> 
> It is a gcc bug, but we'll have to work around it in the ath9k driver.

I imagine that we would be happy to do that.  Anyone have a clue as to how?

John
-- 
John W. Linville
linville@tuxdriver.com

Re: linux-next: wireless-current tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

Hi John,

On Tue, 5 Aug 2008 12:00:26 -0400 "John W. Linville" <linville@tuxdriver.com> wrote:
>
> I imagine that we would be happy to do that.  Anyone have a clue as to how?

I think that "not yet" is the answer :-(

If we don't get a useful answer soon, we may just have to merge the
driver with appropriately commented negative "depends on" in Kconfig for
the arches it breaks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: wireless-current tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

Hi Adrian,

On Tue, 5 Aug 2008 18:37:57 +0300 Adrian Bunk <bunk@kernel.org> wrote:
>
> Alexandros Couloumbis already opened a bug for this issue on mips, which 
> also seems to be affected:
>   http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37014
> 
> It is a gcc bug, but we'll have to work around it in the ath9k driver.

Thanks for fishing that out Adrian.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]