From: Paul Mundt <lethal@linux-sh.org>
To: Benny Halevy <bhalevy@panasas.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Ingo Molnar <mingo@elte.hu>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-next@vger.kernel.org, Andy Adamson <andros@netapp.com>,
Fredric Isaman <iisaman@citi.umich.edu>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Alexander Beregalov <a.beregalov@gmail.com>,
Subrata Modak <subrata@linux.vnet.ibm.com>,
sachinp <sachinp@linux.vnet.ibm.com>
Subject: Re: [PATCH -next] lib: Move find_last_bit.o to obj-y to enable use by modules.
Date: Thu, 23 Apr 2009 19:29:30 +0900 [thread overview]
Message-ID: <20090423102930.GA24434@linux-sh.org> (raw)
In-Reply-To: <49F03F26.4060103@panasas.com>
On Thu, Apr 23, 2009 at 01:12:54PM +0300, Benny Halevy wrote:
> On Apr. 23, 2009, 9:50 +0300, Paul Mundt <lethal@linux-sh.org> wrote:
> > Ok, so we have two different trivial patches for fixing the same thing,
> > and a week later it is still broken.
> >
> > I realize it is a trivial patch, but it does break builds. If folks
> > aren't going to take these sorts of things more seriously, then their
> > tree should be dropped after a grace period (say 2 days or so).
> >
> > Beyond that, it doesn't seem like -next has any sort of coherent policy
> > for dealing with trivial patches. If the emphasis is on the tree that
> > introduced the regression to deal with it, then trees need to be
> > aggressively dropped when these things go unfixed.
> >
> > Having builds broken for a week for an issue that has been spotted and
> > fixed by several people is simply unacceptable.
>
> Paul, that's a valid point but I don't set these polices.
> Trond suggested to just commit this to 2.6.30
> and I asked Rusty's Ack here:
> http://lkml.org/lkml/2009/4/21/489
>
> Like I said there, I'm not sure who to send this patch to.
> Ingo?
>
I was under the impression that a tree that caused a build regression
would be dropped until it had it sorted out, but that seems to be more
the exception than the rule.
-next is good at finding bugs in build configurations folks haven't
considered, which should serve as a pretty good platform for getting
those types of fixes merged quickly, whether it be in to the tree that
caused the regression or -next directly.
Unfortunately it seems like build regressions are more of an afterthought
than a show stopper. I count at least 3 on the sh builds in the last
couple weeks that are all averaging a week or longer to unbreak, while
patches have been available almost immediately.
next prev parent reply other threads:[~2009-04-23 10:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 3:07 [PATCH -next] lib: Move find_last_bit.o to obj-y to enable use by modules Paul Mundt
2009-04-16 8:11 ` Benny Halevy
2009-04-23 6:50 ` Paul Mundt
2009-04-23 10:12 ` Benny Halevy
2009-04-23 10:29 ` Paul Mundt [this message]
2009-04-23 12:59 ` Trond Myklebust
2009-04-23 13:18 ` Benny Halevy
2009-04-23 13:25 ` Paul Mundt
2009-04-23 13:59 ` Trond Myklebust
2009-04-23 14:12 ` Paul Mundt
2009-04-23 16:38 ` Trond Myklebust
2009-04-26 12:49 ` Rusty Russell
2009-04-26 16:42 ` Ingo Molnar
2009-04-26 17:29 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423102930.GA24434@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=Trond.Myklebust@netapp.com \
--cc=a.beregalov@gmail.com \
--cc=andros@netapp.com \
--cc=bhalevy@panasas.com \
--cc=iisaman@citi.umich.edu \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=sachinp@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=subrata@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).