From: Jean Delvare <khali@linux-fr.org>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: linux-next@vger.kernel.org, w.sang@pengutronix.de
Subject: Re: [PATCH] max6875: should depend on I2C
Date: Mon, 4 May 2009 12:48:02 +0200 [thread overview]
Message-ID: <20090504124802.13e56a44@hyperion.delvare> (raw)
In-Reply-To: <1241430586-31878-1-git-send-email-a.beregalov@gmail.com>
Hi Alexander,
On Mon, 4 May 2009 13:49:46 +0400, Alexander Beregalov wrote:
> Fix this build error:
> drivers/built-in.o: In function `max6875_remove':
> max6875.c:(.text+0x6bdda): undefined reference to `i2c_unregister_device'
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> ---
> drivers/misc/eeprom/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig
> index e23f0ec..9118613 100644
> --- a/drivers/misc/eeprom/Kconfig
> +++ b/drivers/misc/eeprom/Kconfig
> @@ -50,7 +50,7 @@ config EEPROM_LEGACY
>
> config EEPROM_MAX6875
> tristate "Maxim MAX6874/5 power supply supervisor"
> - depends on EXPERIMENTAL
> + depends on I2C && EXPERIMENTAL
> help
> If you say yes here you get read-only support for the user EEPROM of
> the Maxim MAX6874/5 EEPROM-programmable, quad power-supply
Good catch! I've folded this fix into
i2c/i2c-chips-move-max6875-to-drivers-misc-eeprom.patch, thanks for
reporting.
--
Jean Delvare
next prev parent reply other threads:[~2009-05-04 10:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 9:49 [PATCH] max6875: should depend on I2C Alexander Beregalov
2009-05-04 10:48 ` Jean Delvare [this message]
2009-05-04 12:55 ` Wolfram Sang
2009-05-04 13:46 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090504124802.13e56a44@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=a.beregalov@gmail.com \
--cc=linux-next@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox