From: Alexander Beregalov <a.beregalov@gmail.com>
To: Borislav Petkov <borislav.petkov@amd.com>,
linux-next@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: next: x86/msr.h: build fails
Date: Wed, 20 May 2009 13:41:41 +0400 [thread overview]
Message-ID: <20090520094141.GA16421@orion> (raw)
Hi Borislav,
What do you think about this fix?
I have no idea what value should be for the cpu variable.
>From 0a72854156436549ccb540fa90f59511470cd188 Mon Sep 17 00:00:00 2001
From: Alexander Beregalov <a.beregalov@gmail.com>
Date: Wed, 20 May 2009 13:33:43 +0400
Subject: [PATCH] x86: msr.h: fix build error
Fix this build error:
.../asm/msr.h: In function 'rdmsr_on_cpus':
.../asm/msr.h:248: error: request for member 'l' in something not a structure or union
.../asm/msr.h:248: error: request for member 'h' in something not a structure or union
.../asm/msr.h:248: error: too few arguments to function 'rdmsr_on_cpu'
.../asm/msr.h: In function 'wrmsr_on_cpus':
.../asm/msr.h:253: error: request for member 'l' in something not a structure or union
.../asm/msr.h:253: error: request for member 'h' in something not a structure or union
.../asm/msr.h:253: error: too few arguments to function 'wrmsr_on_cpu'
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---
arch/x86/include/asm/msr.h | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h
index e49c14e..0b73f73 100644
--- a/arch/x86/include/asm/msr.h
+++ b/arch/x86/include/asm/msr.h
@@ -227,8 +227,8 @@ do { \
#ifdef CONFIG_SMP
int rdmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 *l, u32 *h);
int wrmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 l, u32 h);
-int rdmsr_on_cpus(const cpumask_t *mask, u32 msr_no, struct msr *msrs);
-int wrmsr_on_cpus(const cpumask_t *mask, u32 msr_no, struct msr *msrs);
+int rdmsr_on_cpus(const cpumask_t *mask, u32 msr_no, struct msr **msrs);
+int wrmsr_on_cpus(const cpumask_t *mask, u32 msr_no, struct msr **msrs);
int rdmsr_safe_on_cpu(unsigned int cpu, u32 msr_no, u32 *l, u32 *h);
int wrmsr_safe_on_cpu(unsigned int cpu, u32 msr_no, u32 l, u32 h);
#else /* CONFIG_SMP */
@@ -245,12 +245,12 @@ static inline int wrmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 l, u32 h)
static inline int rdmsr_on_cpus(const cpumask_t *m, u32 msr_no,
struct msr **msrs)
{
- return rdmsr_on_cpu(msr_no, &(msrs[0].l), &(msrs[0].h));
+ return rdmsr_on_cpu(0, msr_no, &(msrs[0]->l), &(msrs[0]->h));
}
static inline int wrmsr_on_cpus(const cpumask_t *m, u32 msr_no,
struct msr **msrs)
{
- return wrmsr_on_cpu(msr_no, msrs[0].l, msrs[0].h);
+ return wrmsr_on_cpu(0, msr_no, msrs[0]->l, msrs[0]->h);
}
static inline int rdmsr_safe_on_cpu(unsigned int cpu, u32 msr_no,
u32 *l, u32 *h)
--
1.6.3.1
next reply other threads:[~2009-05-20 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 9:41 Alexander Beregalov [this message]
2009-05-20 10:14 ` next: x86/msr.h: build fails Alexander Beregalov
2009-05-20 16:06 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520094141.GA16421@orion \
--to=a.beregalov@gmail.com \
--cc=borislav.petkov@amd.com \
--cc=hpa@zytor.com \
--cc=linux-next@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).