From: Borislav Petkov <borislav.petkov@amd.com>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: linux-next@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: next: x86/msr.h: build fails
Date: Wed, 20 May 2009 18:06:34 +0200 [thread overview]
Message-ID: <20090520160634.GB27991@aftab> (raw)
In-Reply-To: <20090520101446.GA16517@orion>
On Wed, May 20, 2009 at 02:14:46PM +0400, Alexander Beregalov wrote:
> On Wed, May 20, 2009 at 01:41:41PM +0400, Alexander Beregalov wrote:
> > Hi Borislav,
> >
> > What do you think about this fix?
> > I have no idea what value should be for the cpu variable.
>
> This patch should be better.
> This is !SMP code, then cpu=0 is ok.
>
>
> From: Alexander Beregalov <a.beregalov@gmail.com>
> Subject: [PATCH] x86: msr.h: fix build error
>
> Fix this build error:
> .../asm/msr.h: In function 'rdmsr_on_cpus':
> .../asm/msr.h:248: error: request for member 'l' in something not a structure or union
> .../asm/msr.h:248: error: request for member 'h' in something not a structure or union
> .../asm/msr.h:248: error: too few arguments to function 'rdmsr_on_cpu'
> .../asm/msr.h: In function 'wrmsr_on_cpus':
> .../asm/msr.h:253: error: request for member 'l' in something not a structure or union
> .../asm/msr.h:253: error: request for member 'h' in something not a structure or union
> .../asm/msr.h:253: error: too few arguments to function 'wrmsr_on_cpu'
>
> This is !SMP code so `cpu` should be 0.
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
thanks, applied.
--
Regards/Gruss,
Boris.
Operating | Advanced Micro Devices GmbH
System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
Research | Geschäftsführer: Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
(OSRC) | Registergericht München, HRB Nr. 43632
prev parent reply other threads:[~2009-05-20 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 9:41 next: x86/msr.h: build fails Alexander Beregalov
2009-05-20 10:14 ` Alexander Beregalov
2009-05-20 16:06 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520160634.GB27991@aftab \
--to=borislav.petkov@amd.com \
--cc=a.beregalov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-next@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).