From: Samuel Ortiz <sameo@linux.intel.com>
To: Daniel Ribeiro <drwyrm@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Harald Welte <laforge@gnumonks.org>,
Philipp Zabel <philipp.zabel@gmail.com>,
openezx-devel <openezx-devel@lists.openezx.org>,
linux-next <linux-next@vger.kernel.org>
Subject: Re: [PATCH v3] MFD: PCAP driver
Date: Fri, 5 Jun 2009 00:54:49 +0200 [thread overview]
Message-ID: <20090604225447.GA4806@sortiz.org> (raw)
In-Reply-To: <1244074856.4767.26.camel@brutus>
Hi Daniel,
On Wed, Jun 03, 2009 at 09:20:56PM -0300, Daniel Ribeiro wrote:
> Em Qua, 2009-06-03 às 16:38 +0200, Geert Uytterhoeven escreveu:
> > > +config EZX_PCAP
> > > + bool "PCAP Support"
> > > + depends on SPI_MASTER
> >
> > It also has to depend on GENERIC_HARDIRQS, as it needs set_irq_type():
>
> Hi Geert, sorry for this. :)
>
>
>
> Fix EZX_PCAP dependency
>
> Signed-off-by: Daniel Ribeiro <drwyrm@gmail.com>
Thanks. Pushed to my for-next branch.
I fixed it on the original patch, to avoid having 2 commits.
Cheers,
Samuel.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 060ee14..6557d60 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -243,7 +243,7 @@ config PCF50633_GPIO
>
> config EZX_PCAP
> bool "PCAP Support"
> - depends on SPI_MASTER
> + depends on GENERIC_HARDIRQS && SPI_MASTER
> help
> This enables the PCAP ASIC present on EZX Phones. This is
> needed for MMC, TouchScreen, Sound, USB, etc..
>
> --
> Daniel Ribeiro
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2009-06-04 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1243399356.2263.46.camel@brutus>
2009-06-03 14:38 ` [PATCH v3] MFD: PCAP driver Geert Uytterhoeven
2009-06-04 0:20 ` Daniel Ribeiro
2009-06-04 22:54 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090604225447.GA4806@sortiz.org \
--to=sameo@linux.intel.com \
--cc=drwyrm@gmail.com \
--cc=geert@linux-m68k.org \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=openezx-devel@lists.openezx.org \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).