* Re: [PATCH v3] MFD: PCAP driver [not found] <1243399356.2263.46.camel@brutus> @ 2009-06-03 14:38 ` Geert Uytterhoeven 2009-06-04 0:20 ` Daniel Ribeiro 0 siblings, 1 reply; 3+ messages in thread From: Geert Uytterhoeven @ 2009-06-03 14:38 UTC (permalink / raw) To: Daniel Ribeiro Cc: Samuel Ortiz, linux-kernel, Harald Welte, Philipp Zabel, openezx-devel, linux-next On Wed, May 27, 2009 at 06:42, Daniel Ribeiro <drwyrm@gmail.com> wrote: > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -241,6 +241,13 @@ config PCF50633_GPIO > Say yes here if you want to include support GPIO for pins on > the PCF50633 chip. > > +config EZX_PCAP > + bool "PCAP Support" > + depends on SPI_MASTER It also has to depend on GENERIC_HARDIRQS, as it needs set_irq_type(): > + set_irq_type(spi->irq, IRQ_TYPE_EDGE_RISING); Cfr. the m68k allmodconfig build failure on linux-next http://kisskb.ellerman.id.au/kisskb/buildresult/595604/: drivers/mfd/ezx-pcap.c:123: error: implicit declaration of function 'get_irq_chip_data' drivers/mfd/ezx-pcap.c:179: error: implicit declaration of function 'note_interrupt' drivers/mfd/ezx-pcap.c:189: error: implicit declaration of function 'get_irq_data' drivers/mfd/ezx-pcap.c:370: error: implicit declaration of function 'set_irq_chip_and_handler' drivers/mfd/ezx-pcap.c:426: error: 'handle_simple_irq' undeclared (first use in this function) drivers/mfd/ezx-pcap.c:426: error: (Each undeclared identifier is reported only once drivers/mfd/ezx-pcap.c:426: error: for each function it appears in.) drivers/mfd/ezx-pcap.c:427: error: implicit declaration of function 'set_irq_chip_data' drivers/mfd/ezx-pcap.c:431: error: implicit declaration of function 'set_irq_noprobe' drivers/mfd/ezx-pcap.c:440: error: implicit declaration of function 'set_irq_type' drivers/mfd/ezx-pcap.c:441: error: implicit declaration of function 'set_irq_data' drivers/mfd/ezx-pcap.c:442: error: implicit declaration of function 'set_irq_chained_handler' drivers/mfd/ezx-pcap.c:443: error: implicit declaration of function 'set_irq_wake' Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] MFD: PCAP driver 2009-06-03 14:38 ` [PATCH v3] MFD: PCAP driver Geert Uytterhoeven @ 2009-06-04 0:20 ` Daniel Ribeiro 2009-06-04 22:54 ` Samuel Ortiz 0 siblings, 1 reply; 3+ messages in thread From: Daniel Ribeiro @ 2009-06-04 0:20 UTC (permalink / raw) To: Geert Uytterhoeven, Samuel Ortiz Cc: linux-kernel, Harald Welte, Philipp Zabel, openezx-devel, linux-next Em Qua, 2009-06-03 às 16:38 +0200, Geert Uytterhoeven escreveu: > > +config EZX_PCAP > > + bool "PCAP Support" > > + depends on SPI_MASTER > > It also has to depend on GENERIC_HARDIRQS, as it needs set_irq_type(): Hi Geert, sorry for this. :) Fix EZX_PCAP dependency Signed-off-by: Daniel Ribeiro <drwyrm@gmail.com> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 060ee14..6557d60 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -243,7 +243,7 @@ config PCF50633_GPIO config EZX_PCAP bool "PCAP Support" - depends on SPI_MASTER + depends on GENERIC_HARDIRQS && SPI_MASTER help This enables the PCAP ASIC present on EZX Phones. This is needed for MMC, TouchScreen, Sound, USB, etc.. -- Daniel Ribeiro ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] MFD: PCAP driver 2009-06-04 0:20 ` Daniel Ribeiro @ 2009-06-04 22:54 ` Samuel Ortiz 0 siblings, 0 replies; 3+ messages in thread From: Samuel Ortiz @ 2009-06-04 22:54 UTC (permalink / raw) To: Daniel Ribeiro Cc: Geert Uytterhoeven, linux-kernel, Harald Welte, Philipp Zabel, openezx-devel, linux-next Hi Daniel, On Wed, Jun 03, 2009 at 09:20:56PM -0300, Daniel Ribeiro wrote: > Em Qua, 2009-06-03 às 16:38 +0200, Geert Uytterhoeven escreveu: > > > +config EZX_PCAP > > > + bool "PCAP Support" > > > + depends on SPI_MASTER > > > > It also has to depend on GENERIC_HARDIRQS, as it needs set_irq_type(): > > Hi Geert, sorry for this. :) > > > > Fix EZX_PCAP dependency > > Signed-off-by: Daniel Ribeiro <drwyrm@gmail.com> Thanks. Pushed to my for-next branch. I fixed it on the original patch, to avoid having 2 commits. Cheers, Samuel. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 060ee14..6557d60 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -243,7 +243,7 @@ config PCF50633_GPIO > > config EZX_PCAP > bool "PCAP Support" > - depends on SPI_MASTER > + depends on GENERIC_HARDIRQS && SPI_MASTER > help > This enables the PCAP ASIC present on EZX Phones. This is > needed for MMC, TouchScreen, Sound, USB, etc.. > > -- > Daniel Ribeiro > -- Intel Open Source Technology Centre http://oss.intel.com/ ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-04 22:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1243399356.2263.46.camel@brutus>
2009-06-03 14:38 ` [PATCH v3] MFD: PCAP driver Geert Uytterhoeven
2009-06-04 0:20 ` Daniel Ribeiro
2009-06-04 22:54 ` Samuel Ortiz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).