From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH -next] ieee802154: fix kconfig bool/tristate muckup Date: Sat, 13 Jun 2009 23:37:37 -0700 (PDT) Message-ID: <20090613.233737.178725457.davem@davemloft.net> References: <4A31869B.3050901@oracle.com> <4A32DDC8.7060605@oracle.com> <20090613105753.GB14520@build.ossfans.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:46401 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751835AbZFNGhe (ORCPT ); Sun, 14 Jun 2009 02:37:34 -0400 In-Reply-To: <20090613105753.GB14520@build.ossfans.org> Sender: linux-next-owner@vger.kernel.org List-ID: To: slapin@ossfans.org Cc: randy.dunlap@oracle.com, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, dbaryshkov@gmail.com, linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org, akpm@linux-foundation.org From: Sergey Lapin Date: Sat, 13 Jun 2009 14:57:54 +0400 > On Fri, Jun 12, 2009 at 03:59:20PM -0700, Randy Dunlap wrote: >> From: Randy Dunlap >> >> menuconfig IEEE802154_DRIVERS is a bool that depends on tristate IEEE802154. >> If the IEEE802154 symbol is 'm', the bool becomes 'y'. >> This allows tristate symbols under IEEE802154_DRIVERS to be configured as >> 'y' and cause build problems. >> Changing the menuconfig bool to a tristate fixes this. >> >> drivers/built-in.o: In function `fake_scan_req': >> fakehard.c:(.text+0x46d625): undefined reference to `ieee802154_nl_scan_confirm' >> drivers/built-in.o: In function `fake_disassoc_req': >> fakehard.c:(.text+0x46d66f): undefined reference to `ieee802154_nl_disassoc_confirm' >> drivers/built-in.o: In function `fake_assoc_req': >> fakehard.c:(.text+0x46d6be): undefined reference to `ieee802154_nl_assoc_confirm' >> >> Signed-off-by: Randy Dunlap >> Cc: linux-zigbee-devel@lists.sourceforge.net >> Cc: Dmitry Eremin-Solenikov >> Cc: Sergey Lapin > Ackedy-by: Sergey Lapin It's "Acked-by:" :-) Applied, thanks everyone.