Re: linux-next: pci tree build failure

Jesse Barnes
2009-03-25T01:44:49Z

On Wed, 25 Mar 2009 12:21:21 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Jesse,
>
> On Mon, 23 Mar 2009 12:49:48 +1100 Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> >
> > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> >
> > arch/powerpc/kernel/msi.c: In function 'arch_msi_check_device':
> > arch/powerpc/kernel/msi.c:23: error: 'PCI_CAP_ID_MSI' undeclared
> > (first use in this function)
> >
> > Caused by commit 1c8d7b0a562da06d3ebe83f01b1ed553205d1ae4 ("PCI
> > MSI: Add support for multiple MSI"). PCI_CAP_ID_MSI is defined in
> > linux/pci_regs.h which is included by linux/pci.h, but neither is
> > included by arch/powerpc/kernel/msi.c.
> >
> > I have used the version of the pci tree from next-20090320 for
> > today.
>
> This is still happening ...

Does this fix it? Some header file changes must be to blame...

diff --git a/arch/powerpc/kernel/msi.c b/arch/powerpc/kernel/msi.c
index 0c16e2a..8bbc12d 100644
--- a/arch/powerpc/kernel/msi.c
+++ b/arch/powerpc/kernel/msi.c
@@ -9,6 +9,7 @@

#include <linux/kernel.h>
#include <linux/msi.h>
+#include <linux/pci.h>

#include <asm/machdep.h>

--
Jesse Barnes, Intel Open Source Technology Center