Re: linux-next: pci tree build failure

Jesse Barnes
2008-10-16T04:30:38Z

On Wednesday, October 15, 2008 8:44 pm Benjamin Herrenschmidt wrote:
> On Thu, 2008-10-16 at 14:41 +1100, Stephen Rothwell wrote:
> > Hi Jesse,
> >
> > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> >
> > drivers/pci/probe.c: In function 'pci_create_legacy_files':
> > drivers/pci/probe.c:69: error: 'pci_read_legacy_io' undeclared (first use
> > in this function) drivers/pci/probe.c:70: error: 'pci_write_legacy_io'
> > undeclared (first use in this function) drivers/pci/probe.c:80: error:
> > 'pci_mmap_legacy_mem' undeclared (first use in this function)
> >
> > Direct cause (probably) is commit
> > 913d3708831ec551ca8560ea2cc793f738df88d6 ("powerpc/PCI: Add legacy PCI
> > access via sysfs") which I have reverted. Actually caused by the removal
> > of commit
> > d965c04f27d4df28b1ce77b0aea6329c07a8e13d ("PCI: Add ability to mmap
> > legacy_io on some platforms") which the above commit depends on.
>
> Yup, Jesse, patch 1/2 is still good :-) It's patch 2/2 that I've been
> updating 3 times :-)

Hm, I must have applied the wrong ones... but I didn't do a ppc build to test.
I'll fix it up.

Thanks,
Jesse