Re: linux-next: pci tree build failure

Alan Stern
2008-06-30T14:11:18Z

On Mon, 30 Jun 2008, Stephen Rothwell wrote:

> Hi Jesse,
>
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>
> drivers/usb/core/driver.c: In function 'do_unbind_rebind':
> drivers/usb/core/driver.c:865: error: 'struct dev_pm_info' has no member named 'sleeping'
>
> Due to commit 1eede070a59e1cc73da51e1aaa00d9ab86572cfc ("Introduce new
> top level suspend and hibernation callbacks") from the pci tree (which
> removed the sleeping field of the dev_pm_info structure) and commit
> fafa0857b87640d4c297777d432174b8778ac4fd ("USB: Force unbinding of
> drivers lacking reset_resume or other methods") from the usb tree which
> adds a reference.

I knew this was going to happen. There was no way around it.

> For now I have reverted commit fafa0857b87640d4c297777d432174b8778ac4fd
> ("USB: Force unbinding of drivers lacking reset_resume or other methods")
> from the usb tree since that gives me a building tree without the pain of
> trying to revert 1eede070a59e1cc73da51e1aaa00d9ab86572cfc (which has
> several dependent commits).
>
> A better solution would be nice (hint, hint).

Instead of reverting that USB commit, take a look at it. There's a big
FIXME comment at the point where the obsolete field member is used.
For now you can insert a patch to remove that line of code.

That's not a correct fix, but it will allow things to build and run.
Unfortunately it's not possible at this time to submit a correct fix
because the clash occurs between patches in two different development
trees. In addition, the correct fix involves a non-trivial rewrite of
the USB-PM interface; it can't simply be dashed off.

Alan Stern