linux-next: sfi tree build warning

linux-next: sfi tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hi all,

Today's linux-next build (x86_64 allmodconfig) produced this warning:

arch/x86/kernel/sfi.c: In function 'sfi_init_memory_map':
arch/x86/kernel/sfi.c:99: warning: cast to pointer from integer of different size
arch/x86/kernel/sfi.c:100: warning: cast to pointer from integer of different size

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [SFI-devel] linux-next: sfi tree build warning

[Feng Tang]

On Wed, 8 Jul 2009 14:44:00 +0800
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
> 
> arch/x86/kernel/sfi.c: In function 'sfi_init_memory_map':
> arch/x86/kernel/sfi.c:99: warning: cast to pointer from integer of
> different size arch/x86/kernel/sfi.c:100: warning: cast to pointer
> from integer of different size
> 
Hi Stephen,

Thanks for the finding. Could you help to test the following quick patch?
it should works for both x86_32 and x86_64. thanks

- Feng 

diff --git a/arch/x86/kernel/sfi.c b/arch/x86/kernel/sfi.c
index a96ea0f..b23e489 100644
--- a/arch/x86/kernel/sfi.c
+++ b/arch/x86/kernel/sfi.c
@@ -96,8 +96,9 @@ int __init sfi_init_memory_map(void)
	/* walk through the syst to search the mmap table */
	mmapt = NULL;
	for (i = 0; i < tbl_cnt; i++) {
-		if (!strncmp(SFI_SIG_MMAP, (char *)(u32)*pentry, 4)) {
-			mmapt = (struct sfi_table_simple *)(u32)*pentry;
+		if (!strncmp(SFI_SIG_MMAP, (char *)(unsigned long)*pentry, 4)) {
+			mmapt = (struct sfi_table_simple *)
+					(unsigned long)*pentry;
			break;
                }
		pentry++;

Re: [SFI-devel] linux-next: sfi tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

Hi Feng,

On Wed, 8 Jul 2009 14:57:40 +0800 Feng Tang <feng.tang@intel.com> wrote:
>
> Thanks for the finding. Could you help to test the following quick patch?
> it should works for both x86_32 and x86_64. thanks

That patch makes the warning go away for an x86_84 allmodconfig build.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [SFI-devel] linux-next: sfi tree build warning

[Len Brown]

> Today's linux-next build (x86_64 allmodconfig) produced this warning:

ah good, this means the SFI tree actually made it into linux-next:-)

> arch/x86/kernel/sfi.c: In function 'sfi_init_memory_map':
> arch/x86/kernel/sfi.c:99: warning: cast to pointer from integer of different size
> arch/x86/kernel/sfi.c:100: warning: cast to pointer from integer of different size

This should go away when you pull the patch below for tomorrow's build.

thanks,
Len Brown, Intel Open Source Technology Center


commit 6a099c4dfc3e3fa95e55ea13ce836a6ed98ee689
Author: Feng Tang <feng.tang@intel.com>
Date:   Wed Jul 8 17:35:45 2009 +0800

    SFI: fix the compile warning for x86_64

Re: [SFI-devel] linux-next: sfi tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

Hi Len,

On Wed, 08 Jul 2009 11:26:48 -0400 (EDT) Len Brown <lenb@kernel.org> wrote:
>
> > Today's linux-next build (x86_64 allmodconfig) produced this warning:
> 
> ah good, this means the SFI tree actually made it into linux-next:-)

Indeed :-)

> > arch/x86/kernel/sfi.c: In function 'sfi_init_memory_map':
> > arch/x86/kernel/sfi.c:99: warning: cast to pointer from integer of different size
> > arch/x86/kernel/sfi.c:100: warning: cast to pointer from integer of different size
> 
> This should go away when you pull the patch below for tomorrow's build.

Great, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]