From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH] percpu: add dummy pcpu_lpage_remapped() for !CONFIG_SMP
Date: Wed, 15 Jul 2009 21:55:56 +0530 [thread overview]
Message-ID: <20090715162556.GA4767@linux.vnet.ibm.com> (raw)
In-Reply-To: <4A5DEA0D.8050706@gmail.com>
* Tejun Heo <htejun@gmail.com> [2009-07-15 23:39:09]:
> !CONFIG_SMP was missing pcpu_lpage_remapped() definition causing build
> failure. Add dummy implementation. This was discovered by linux-next
> testing.
>
Thanks, the patch fixes the build failure.
Tested-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> Yeap, it was missing dummy definition on !CONFIG_SMP. This patch
> fixes it. Committed to percpu#for-next. Thanks.
>
> include/linux/percpu.h | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/percpu.h b/include/linux/percpu.h
> index 8ce91af..e134c82 100644
> --- a/include/linux/percpu.h
> +++ b/include/linux/percpu.h
> @@ -184,6 +184,11 @@ static inline void free_percpu(void *p)
>
> static inline void __init setup_per_cpu_areas(void) { }
>
> +static inline void *pcpu_lpage_remapped(void *kaddr)
> +{
> + return NULL;
> +}
> +
> #endif /* CONFIG_SMP */
>
> #define alloc_percpu(type) (type *)__alloc_percpu(sizeof(type), \
> --
> 1.6.0.2
Kamalesh
prev parent reply other threads:[~2009-07-15 16:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 6:26 linux-next: Tree for July 6 Stephen Rothwell
2009-07-06 16:53 ` linux-next: Tree for July 6 (percpu/x86) Randy Dunlap
2009-07-09 17:22 ` linux-next: Tree for July 6-July 9 (percpu/x86) Randy Dunlap
2009-07-15 9:47 ` linux-next: Tree for July 6-July 9-July 15 (percpu/x86) Kamalesh Babulal
2009-07-15 9:58 ` Stephen Rothwell
2009-07-15 10:02 ` Tejun Heo
2009-07-15 14:39 ` [PATCH] percpu: add dummy pcpu_lpage_remapped() for !CONFIG_SMP Tejun Heo
2009-07-15 16:25 ` Kamalesh Babulal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090715162556.GA4767@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).