From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: Boot failure on x86_64 (OOPS set_cpu_sibling_map() ) Date: Tue, 4 Aug 2009 17:00:46 +0200 Message-ID: <20090804150046.GD1870@aftab> References: <20090730182143.eadf36e6.sfr@canb.auug.org.au> <4A718338.6050907@in.ibm.com> <20090730135623.GB16659@aftab> <20090803093144.GC9074@elte.hu> <20090803101401.GA14442@aftab> <20090803120739.GA29156@elte.hu> <20090803125059.GB14442@aftab> <20090804135029.GA6775@elte.hu> <20090804143150.GC1870@aftab> <20090804144741.GL7746@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20090804144741.GL7746@elte.hu> Sender: linux-kernel-owner@vger.kernel.org To: Ingo Molnar Cc: Andreas Herrmann , "H. Peter Anvin" , Thomas Gleixner , Sachin Sant , Stephen Rothwell , linux-next@vger.kernel.org, LKML , Ingo Molnar List-Id: linux-next.vger.kernel.org On Tue, Aug 04, 2009 at 04:47:41PM +0200, Ingo Molnar wrote: >=20 > * Borislav Petkov wrote: >=20 > > On Tue, Aug 04, 2009 at 03:50:29PM +0200, Ingo Molnar wrote: > > > > > Mind preparing a separate branch for it (.31-rc5 based) and s= end me=20 > > > > > a pull request so that we can share the commit between the ED= AC tree=20 > > > > > and the x86 tree? > > > >=20 > > > > Well, Andreas says the patches need a little polishing and he'l= l=20 > > > > be sending updated versions soon so you can pick them up. And=20 > > > > since the EDAC MCE stuff might still change before .32 merge=20 > > > > window opens, let's synchronize our pull requests instead. In t= he=20 > > > > meantime, I'll be rediffing the EDAC stuff against -tip for=20 > > > > linux-next. > > >=20 > > > Would you rebase just due to this commit? > >=20 > > No, I wanted to keep the opportunity to be able to rebase the=20 > > whole series until the very last minute before the merge window,=20 > > should anything need to be changed... >=20 > Note that's the wrong workflow. We dont rebase Git trees really just=20 > because 'something needs to be changed' - we make sure all commits=20 > make sense, we fix bugs and append new changes to the end. That=20 > results in a far better end result than a constant rebasing=20 > workflow. See various mails from Linus on lkml about this topic. (i=20 > have no handy URL for this now - maybe someone else has) Yep, that I know and I agree with completely, I'm simply waiting in cas= e there are more comments on the subject (looka here, the last one was from you :o)). Also, considering that some aspects to the design aren't final, I'd like to be able to rebase. However, I'll make sure I switch to incremental workflow after the majority of the issues are agreed upon. > > > No need for that, feel free to carry it until Andreas sends an > > > updated version. Then i can put it into a separate .31-rc5 based > > > topic that you can pull into the EDAC tree. > > > > ... and this is basically what I had in mind: After you pull them > > in, I'll rebase my branch against yours for linux-next. I see > > that Stephen pulls edac before -tip in linux-next so I'll ask him > > nicely to reorder those. This approach makes most sense anyways > > since edac relies on a bunch of x86 facilities (topology bits, > > rd/wrmsr_on_cpus, mcheck etc) and it is only natural that it goes > > second in linux-next, right? > > > > Then the pull requests will go out in the same order during the > > merge window and we should be fine. > > ok. I'll wait for Andreas's next version of the patch. Feel free to > carry the interim version - just please dont crash the x86 bootup ;-) /me going to kick him to work faster :). --=20 Regards/Gruss, Boris. Operating | Advanced Micro Devices GmbH System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. M=FCnchen, Ger= many Research | Gesch=E4ftsf=FChrer: Thomas M. McCoy, Giuliano Meroni Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis M=FCnchen (OSRC) | Registergericht M=FCnchen, HRB Nr. 43632