linux-next: nfsd tree build warning

linux-next: nfsd tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

Hi Bruce,

Today's linux-next build (powerpc ppc64_defconfig) produced this warning:

net/sunrpc/svc_xprt.c: In function 'svc_pool_stats_show':
net/sunrpc/svc_xprt.c:1211: warning: too few arguments for format

Caused by commit ffcef87a1f31094709da615454b5911f3711bc65 ("Revert
"knfsd: avoid overloading the CPU scheduler with enormous load
averages"").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: nfsd tree build warning

[J. Bruce Fields]

On Tue, Aug 11, 2009 at 11:07:49AM +1000, Stephen Rothwell wrote:
> Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
> 
> net/sunrpc/svc_xprt.c: In function 'svc_pool_stats_show':
> net/sunrpc/svc_xprt.c:1211: warning: too few arguments for format
> 
> Caused by commit ffcef87a1f31094709da615454b5911f3711bc65 ("Revert
> "knfsd: avoid overloading the CPU scheduler with enormous load
> averages"").

Whoops, thanks: fixed.

--b.

linux-next: nfsd tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

Hi Bruce,

Today's linux-next build (powerpc ppc64_defconfig) produced this new
warning:

fs/nfsd/nfs4state.c: In function 'EXPIRED_STATEID':
fs/nfsd/nfs4state.c:2757: warning: comparison of distinct pointer types lacks a cast

Caused by commit 78155ed75f470710f2aecb3e75e3d97107ba8374 ("nfsd4:
distinguish expired from stale stateids").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: nfsd tree build warning

[J. Bruce Fields]

On Wed, Apr 29, 2009 at 01:57:02PM +1000, Stephen Rothwell wrote:
> Hi Bruce,
> 
> Today's linux-next build (powerpc ppc64_defconfig) produced this new
> warning:
> 
> fs/nfsd/nfs4state.c: In function 'EXPIRED_STATEID':
> fs/nfsd/nfs4state.c:2757: warning: comparison of distinct pointer types lacks a cast
> 
> Caused by commit 78155ed75f470710f2aecb3e75e3d97107ba8374 ("nfsd4:
> distinguish expired from stale stateids").
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/

Probably just needs yet another cast.  Argh; maybe Bian Naimeng's
after_boot()/before_lease() idea would have been simpler.

--b.


diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 74e822e..d24dd12 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2754,7 +2754,7 @@ EXPIRED_STATEID(stateid_t *stateid)
 {
 	if (time_before((unsigned long)boot_time,
 			((unsigned long)stateid->si_boot)) &&
-	    time_before((stateid->si_boot + lease_time), get_seconds())) {
+	    time_before((unsigned long)(stateid->si_boot + lease_time), get_seconds())) {
 		dprintk("NFSD: expired stateid (%08x/%08x/%08x/%08x)!\n",
 			stateid->si_boot, stateid->si_stateownerid,
 			stateid->si_fileid, stateid->si_generation);

linux-next: nfsd tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

Hi Bruce,

Today's linux-next build (powerpc ppc64_defconfig) produced this warning:

fs/nfsd/nfs4recover.c: In function 'nfsd4_build_namelist':
fs/nfsd/nfs4recover.c:203: warning: array subscript is above array bounds

Caused by commit d1d269b9d0cadf221cfa3ddbe65a3a0e4cf100e1 ("nfsd4: don't
do lookup within readdir in recovery code").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: nfsd tree build warning

[J. Bruce Fields]

On Mon, Mar 16, 2009 at 04:51:21PM +1100, Stephen Rothwell wrote:
> Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
> 
> fs/nfsd/nfs4recover.c: In function 'nfsd4_build_namelist':
> fs/nfsd/nfs4recover.c:203: warning: array subscript is above array bounds
> 
> Caused by commit d1d269b9d0cadf221cfa3ddbe65a3a0e4cf100e1 ("nfsd4: don't
> do lookup within readdir in recovery code").

That should be fixed now, thanks.--b.

Re: linux-next: nfsd tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

Hi Bruce,

On Mon, 16 Mar 2009 09:42:45 -0400 "J. Bruce Fields" <bfields@fieldses.org> wrote:
>
> That should be fixed now, thanks.--b.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]