From: Greg KH <gregkh@suse.de>
To: Randy Dunlap <rdunlap@xenotime.net>, Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-next <linux-next@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] staging/sep: fix build error & warning & kconfig
Date: Mon, 17 Aug 2009 13:42:09 -0700 [thread overview]
Message-ID: <20090817204209.GA9274@suse.de> (raw)
In-Reply-To: <4A89BF12.6020908@xenotime.net>
On Mon, Aug 17, 2009 at 01:35:30PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix sep_driver build when CONFIG_PCI=n:
>
> drivers/staging/sep/sep_driver.c:2548: error: implicit declaration of function 'pci_dev_get'
I just merged a patch to fix this a few minutes ago.
> and printk format warning:
>
> drivers/staging/sep/sep_driver.c:290:
> warning: format '%d' expects type 'int', but argument 2 has type 'long unsigned
> int'
I think Alan is taking care of this stuff already.
> Also, the default kconfig value should not be 'y'.
>
> And something should be done about this warning (but I didn't fix it):
> drivers/staging/sep/sep_driver.c:1780: warning: 'error' may be used uninitialized in this function
Alan has already resolved this one.
thanks,
greg k-h
prev parent reply other threads:[~2009-08-17 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 20:35 [PATCH -next] staging/sep: fix build error & warning & kconfig Randy Dunlap
2009-08-17 20:42 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090817204209.GA9274@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).