linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>
Cc: randy.dunlap@oracle.com, linux-kernel@vger.kernel.org,
	linux-next@vger.kernel.org, akpm@linux-foundation.org,
	nhorman@tuxdriver.com, rostedt@goodmis.org
Subject: Re: [PATCH -next] trace_skb: fix build when CONFIG_NET is not enabled
Date: Tue, 18 Aug 2009 01:03:26 +0200	[thread overview]
Message-ID: <20090817230326.GB16222@elte.hu> (raw)
In-Reply-To: <20090817.155942.143261709.davem@davemloft.net>


* David Miller <davem@davemloft.net> wrote:

> From: Ingo Molnar <mingo@elte.hu>
> Date: Tue, 18 Aug 2009 00:47:27 +0200
> 
> > Also, has the review feedback from the tracing folks been 
> > addressed? Please separate these patches out and lets do this 
> > properly, this approach is not acceptable.
> 
> Fine, will keep you guys in the loop next time :-)

thanks

If the TRACE_EVENT() form is used then it can be done just fine 
from the networking tree too by enhancing 
include/trace/events/skb.h - TRACE_EVENT() is a decentralized 
facility.

We try not to add new ftrace plugins but extend the set of generic 
tracepoints.

	Ingo

  reply	other threads:[~2009-08-17 23:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-17 20:37 [PATCH -next] trace_skb: fix build when CONFIG_NET is not enabled Randy Dunlap
2009-08-17 21:58 ` Ingo Molnar
2009-08-17 22:33   ` David Miller
2009-08-17 22:47     ` Ingo Molnar
2009-08-17 22:59       ` David Miller
2009-08-17 23:03         ` Ingo Molnar [this message]
2009-08-17 23:00       ` Ingo Molnar
2009-08-17 23:00 ` David Miller
2009-08-17 23:06   ` Ingo Molnar
2009-08-18  0:03     ` David Miller
2009-08-18 12:13       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090817230326.GB16222@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=randy.dunlap@oracle.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).