From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH -next] trace_skb: fix build when CONFIG_NET is not enabled Date: Tue, 18 Aug 2009 14:13:52 +0200 Message-ID: <20090818121352.GA20286@elte.hu> References: <4A89BF90.5070202@oracle.com> <20090817.160041.40869355.davem@davemloft.net> <20090817230654.GC16222@elte.hu> <20090817.170337.139340805.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:44126 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370AbZHRMOQ (ORCPT ); Tue, 18 Aug 2009 08:14:16 -0400 Content-Disposition: inline In-Reply-To: <20090817.170337.139340805.davem@davemloft.net> Sender: linux-next-owner@vger.kernel.org List-ID: To: David Miller Cc: randy.dunlap@oracle.com, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, akpm@linux-foundation.org, nhorman@tuxdriver.com, rostedt@goodmis.org * David Miller wrote: > From: Ingo Molnar > Date: Tue, 18 Aug 2009 01:06:54 +0200 > > > ... but these are the wrong patches, they should be removed or > > reverted and redone properly. > > Given the number of users of net-next-2.6, removal via rebasing > is simply not an option. The other two posibilities, sure... > > > It's not just about keeping kernel/trace/* changes in the > > tracing tree (which we can relax on-demand given agreement), > > it's that these patches are also _wrong_ and we cannot relax > > anything about that. > > Why don't we give Neil a chance to review the situation and fix > things up? > > If revert is the final decision, that's fine, I'll revert > everything. > > But in the mean time at least give Neil a chance to read all of > your feedback and coordinate a way to fix things with everyone. Oh, sure. Conversion to TRACE_EVENT() is equivalent to the revert of the current patches plus introduction of the TRACE_EVENT() defines. Ingo