Re: [PATCH]:Fix warnings from drivers/i2c/i2c-core.c

[Jean Delvare <khali@linux-fr.org>]

Hi Vibi,

On Tue, 11 Aug 2009 13:23:46 +0530, vibi sreenivasan wrote:
> 
> Fix Following Warnings
> 
> drivers/i2c/i2c-core.c:234: warning: initialization from incompatible pointer type
> drivers/i2c/i2c-core.c:537: warning: initialization from incompatible pointer type

Thanks for reporting. Please add the linux-i2c list in Cc next time too.

> Signed-off-by: vibi sreenivasan, CMS COMPUTERS LTD, INDIA <vibi_sreenivasan@cms.com>

Signed-off-by lines should only include developer names, not companies
names nor countries.

> ---
>  drivers/i2c/i2c-core.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> index eeb9ae5..8d80fce 100644
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -214,7 +214,7 @@ static struct attribute_group i2c_dev_attr_group = {
>         .attrs          = i2c_dev_attrs,
>  };
>  
> -static struct attribute_group *i2c_dev_attr_groups[] = {
> +static const struct attribute_group *i2c_dev_attr_groups[] = {
>         &i2c_dev_attr_group,
>         NULL
>  };
> @@ -528,7 +528,7 @@ static struct attribute_group i2c_adapter_attr_group = {
>         .attrs          = i2c_adapter_attrs,
>  };
>  
> -static struct attribute_group *i2c_adapter_attr_groups[] = {
> +static const struct attribute_group *i2c_adapter_attr_groups[] = {
>         &i2c_adapter_attr_group,
>         NULL
>  };

Patch was corrupted by your e-mail client, I wasn't able to apply it.
Please check your configuration for next time.

Anyway, as these warnings are introduced by patches which have not been
committed yet, I will update these patches rather than adding the fixes
as a separate patch.

-- 
Jean Delvare