Linux-Next discussions
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Len Brown <len.brown@intel.com>
Subject: linux-next: dwmw2-iommu tree build failure
Date: Mon, 31 Aug 2009 15:24:23 +1000	[thread overview]
Message-ID: <20090831152423.13e06c4a.sfr@canb.auug.org.au> (raw)

Hi David,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/pci/intel-iommu.c: In function 'iommu_prepare_identity_map':
drivers/pci/intel-iommu.c:1979: error: implicit declaration of function 'dmi_get_system_info'

Caused by commit 2ff729f5445cc47d1910386c36e53fc6b1c5e47a ("intel-iommu:
Cope with yet another BIOS screwup causing crashes") from the dwmw2-iommu
tree interacting with commit 2e15511d37cded52140573b72c3b5b085fdb7f80
("ACPI: linux/acpi.h should not include linux/dmi.h") from he acpi tree.

This file needs to include linux/dmi.h directly ... I applied the
following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 31 Aug 2009 15:20:33 +1000
Subject: [PATCH] intel-iommu: include linux/dmi.h to use dmi_ routines

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/pci/intel-iommu.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
index d36fa80..2ec5899 100644
--- a/drivers/pci/intel-iommu.c
+++ b/drivers/pci/intel-iommu.c
@@ -37,6 +37,7 @@
 #include <linux/iommu.h>
 #include <linux/intel-iommu.h>
 #include <linux/sysdev.h>
+#include <linux/dmi.h>
 #include <asm/cacheflush.h>
 #include <asm/iommu.h>
 #include "pci.h"
-- 
1.6.3.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

             reply	other threads:[~2009-08-31  5:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-31  5:24 Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-07-15  4:01 linux-next: dwmw2-iommu tree build failure Stephen Rothwell
2009-07-15  7:29 ` David Woodhouse
2009-07-15  7:32   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090831152423.13e06c4a.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=dwmw2@infradead.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox