From: Fenghua Yu <fenghua.yu@intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Dave Airlie <airlied@redhat.com>
Cc: Tony luck <tony.luck@intel.com>,
linux-ia64 <linux-ia64@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
linux-next <linux-next@vger.kernel.org>
Subject: [PATCH] linux-next drm_cache.c: fix compilation error
Date: Mon, 31 Aug 2009 12:28:35 -0700 [thread overview]
Message-ID: <20090831192834.GA10462@linux-os.sc.intel.com> (raw)
In-Reply-To: <20090804221119.GA21544@linux-os.sc.intel.com>
When compiling drm_cache.c on ia64, gcc reports undefined
drm_clflush_ipi_handler() error. The problem is because drm_cache_ipi_handler is
a typo.
One straightforward fix is changing drm_cache_ipi_handler to
drm_clflush_ipi_handler.
But since drm_clflush_ipi_handler() does nothing on non-x86 platforms and ipi
handling is costly, it would be better to just do nothing on non-x86 platforms
and remove drm_clflush_ipi_handler() for those platforms.
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
---
The issue was introduced by commit c9c97b8c75019814d8c007059bc827bb475be917
in linux-next.
drm_cache.c | 7 -------
1 files changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
index 3a5575e..8054a5c 100644
--- a/drivers/gpu/drm/drm_cache.c
+++ b/drivers/gpu/drm/drm_cache.c
@@ -62,10 +62,6 @@ drm_clflush_ipi_handler(void *null)
{
wbinvd();
}
-#elif !defined(__powerpc__)
-static void drm_cache_ipi_handler(void *dummy)
-{
-}
#endif
void
drm_clflush_pages(struct page *pages[], unsigned long num_pages)
@@ -94,9 +90,6 @@ drm_clflush_pages(struct page *pages[], unsigned long num_pages)
(unsigned long)page_virtual + PAGE_SIZE);
kunmap_atomic(page_virtual, KM_USER0);
}
-#else
- if (on_each_cpu(drm_clflush_ipi_handler, NULL, 1) != 0)
- printk(KERN_ERR "Timed out waiting for drm cache flush\n");
#endif
}
EXPORT_SYMBOL(drm_clflush_pages);
parent reply other threads:[~2009-08-31 19:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20090804221119.GA21544@linux-os.sc.intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090831192834.GA10462@linux-os.sc.intel.com \
--to=fenghua.yu@intel.com \
--cc=airlied@redhat.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).