linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	shemminger@vyatta.com
Subject: Re: linux-next: net tree build warning
Date: Mon, 07 Sep 2009 02:04:23 -0700 (PDT)	[thread overview]
Message-ID: <20090907.020423.151248729.davem@davemloft.net> (raw)
In-Reply-To: <20090904144232.1f6ccf45.sfr@canb.auug.org.au>

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 4 Sep 2009 14:42:32 +1000

> Today's linux-next build (x86_64 allmodconfig gcc-4.4.0) produced this warning:
> 
> drivers/net/r8169.c: In function 'rtl8169_start_xmit':
> drivers/net/r8169.c:3421: warning: label 'out' defined but not used
> 
> Introduced by commit 61357325f377889a1daffa14962d705dc814dd0e ("netdev:
> convert bulk of drivers to netdev_tx_t").

Thanks for the report, I'll commit the fix below.

Also, Stephen Hemminger has fixed the dlci WAN driver warning
you reported too.

r8169: Fix warning in rtl8169_start_xmit().

Reported by Stephen Rothwell:

drivers/net/r8169.c: In function 'rtl8169_start_xmit':
drivers/net/r8169.c:3421: warning: label 'out' defined but not used

Introduced by commit 61357325f377889a1daffa14962d705dc814dd0e ("netdev:
convert bulk of drivers to netdev_tx_t").

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/r8169.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index a91e9b3..50c6a3c 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -3416,7 +3416,6 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
 			netif_wake_queue(dev);
 	}
 
-out:
 	return NETDEV_TX_OK;
 
 err_stop:
-- 
1.6.4.2

       reply	other threads:[~2009-09-07  9:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090904144232.1f6ccf45.sfr@canb.auug.org.au>
2009-09-07  9:04 ` David Miller [this message]
2009-09-07  9:37   ` linux-next: net tree build warning Stephen Rothwell
2009-11-30  5:40 Stephen Rothwell
2009-11-30  9:49 ` Andrei Pelinescu-Onciul
  -- strict thread matches above, loose matches on Subject: below --
2009-11-12  2:24 Stephen Rothwell
2009-11-12  2:53 ` David Miller
2009-11-12  2:55   ` Eric Dumazet
2009-11-12  3:10   ` Stephen Rothwell
2009-11-05  2:30 Stephen Rothwell
2009-09-04  4:28 Stephen Rothwell
2009-09-04  4:35 ` David Miller
2009-06-09 10:36 Stephen Rothwell
2009-06-09 11:25 ` Wolfgang Grandegger
2009-06-09 11:26   ` David Miller
2009-06-09 13:14     ` Wolfgang Grandegger
2009-06-10  0:38       ` David Miller
2009-06-10  7:38         ` Wolfgang Grandegger
2009-06-10  8:12           ` David Miller
2009-05-22  5:16 Stephen Rothwell
2009-05-22  6:30 ` David Miller
2009-05-22  8:20   ` Stephen Rothwell
2009-05-22 10:31     ` Neil Horman
2009-03-12  5:58 Stephen Rothwell
2009-03-12  6:24 ` David Miller
2009-03-12  6:42   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090907.020423.151248729.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).